Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid url #104

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
1 participant
@nctl144
Copy link
Member

commented Mar 1, 2018

Hey guys, this might be a solution to the issue mentioned in scrapy/scrapy#1304 and the continuation of the PR scrapy/scrapy#2955. I found this issue interesting so I thought it might be a good idea to write some code.
@kmike what do you think?

@codecov

This comment has been minimized.

Copy link

commented Mar 1, 2018

Codecov Report

Merging #104 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage   95.31%   95.37%   +0.05%     
==========================================
  Files           7        7              
  Lines         470      476       +6     
  Branches       95       96       +1     
==========================================
+ Hits          448      454       +6     
  Misses         15       15              
  Partials        7        7
Impacted Files Coverage Δ
w3lib/url.py 97.98% <100%> (+0.06%) ⬆️
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.