Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter tel scheme issue #1381 #105

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
2 participants
@nctl144
Copy link
Member

commented Mar 3, 2018

Hey guys, I made this PR to solve the issue from scrapy/scrapy#1381. I thought it was a good idea to filter out the tel scheme if there's any in the url path since theres no information we can get from that url. What do you guys think? :)

@codecov

This comment has been minimized.

Copy link

commented Mar 3, 2018

Codecov Report

Merging #105 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
+ Coverage   95.31%   95.36%   +0.04%     
==========================================
  Files           7        7              
  Lines         470      475       +5     
  Branches       95       96       +1     
==========================================
+ Hits          448      453       +5     
  Misses         15       15              
  Partials        7        7
Impacted Files Coverage Δ
w3lib/url.py 97.97% <100%> (+0.05%) ⬆️
@kmike

This comment has been minimized.

Copy link
Member

commented Jul 4, 2018

Hey @nctl144! I agree that we should fix it somehow, but stripping tel: from path looks wrong, we should fix the issue at earlier stages, likely at urljoin. So I'm closing this PR, but I think fixing it is still important.

@kmike kmike closed this Jul 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.