Add QueueManager & improve TaskQueue #393
Open
+363
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds a QueueManager class to manage multiple throttling queues and refactors TaskQueue to remove the p-limit dependency by implementing custom concurrency control. The changes also optimize canvas operations by adding willReadFrequently: true to 2D context creation.
- Introduces
QueueManagerfor convenient management of multiple per-host throttling queues - Refactors
TaskQueueconcurrency logic to provide proper back pressure and remove external dependency - Adds canvas optimization flags to fix Chrome warnings and potential buffer corruption
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/task-herder/src/QueueManager.ts | New class for managing multiple named task queues with shared/individual configurations |
| packages/task-herder/test/manager.test.ts | Comprehensive test coverage for QueueManager API including create, get, and getOrCreate methods |
| packages/task-herder/src/index.ts | Exports the new QueueManager class |
| packages/task-herder/src/TaskQueue.ts | Refactored concurrency control with custom implementation, removed p-limit dependency, added options getter |
| packages/task-herder/package.json | Removed p-limit dependency |
| package-lock.json | Removed p-limit and yocto-queue dependencies from task-herder |
| packages/scratch-vm/src/import/load-costume.js | Added willReadFrequently flag to canvas 2D context for bitmap loading |
| packages/scratch-render/src/BitmapSkin.js | Added willReadFrequently flag with explanatory comment for WebGL texture data extraction |
| packages/scratch-gui/webpack.config.js | Added vendor chunks copying for scratch-storage npm link support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Contributor
Contributor
Contributor
Contributor
This fixes a Chrome crash when loading assets with moderately high concurrency. It's also allegedly a good idea for performance.
cwillisf
force-pushed
the
task-queue-manager
branch
from
981844b to
1be24de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Supports an upcoming
scratch-storagechange that will resolve scratchfoundation/scratch-gui#7111 and POD-238Proposed Changes
Main change: in
task-herder, addQueueManager, a way to conveniently manage multiple throttling queues.Supporting changes:
QueueManagerTaskQueuescratch-storage, which helps when usingnpm link scratch-storage{willReadFrequently: true}to theCanvas.getContext('2d')call in the bitmap load pathReason for Changes
scratch-storagechange will use this newQueueManagerto manage per-host throttling queues.p-limitdependency is a nice side effect. (There's nothing wrong withp-limit, but fewer dependencies is better.)willReadFrequentlychange:Test Coverage
The new
QueueManageris covered by new tests. Existing tests cover everything else.