feat(load): Allow caller to specify data format for an asset fetch #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling `load`, you may now explicitly state a data format / file extension. If you don't specify one, the default for that asset type will be used. Resolves scratchfoundation#7
cwillisf
force-pushed
the
override-data-format
branch
from
5cd2a7e to
19f4699
Compare
rschamp
approved these changes
May 31, 2017
| const assetInfo = testAssets[i]; | ||
|
|
||
| const promise = storage.load(assetInfo.type, assetInfo.id); | ||
| var promise = storage.load(assetInfo.type, assetInfo.id, assetInfo.ext); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #7
Proposed Changes
When calling
load, you may now explicitly state a data format / file extension. If you don'tspecify one, the default for that asset type will be used.
Reason for Changes
This allows loading assets whose file extensions don't match the default data format. For example, this allows loading JPEG-format backdrops.
Test Coverage
I added several test cases to the "download known assets" integration test. These new cases ensure that we're covering
loadboth with and without specifying the data format, as well as explicitly specifying a non-default format.