Don't use separate web entry point: let UMD do it #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using UMD for the web build conflicts with the old `index-web.js` file, since they both try to do roughly the same thing. This change should have been part of the recent switch to UMD output for `dist/web`.
thisandagain
approved these changes
Oct 3, 2017
Contributor
thisandagain
left a comment
thisandagain
left a comment
There was a problem hiding this comment.
This LGTM and seems more reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Test failures when building
scratch-guiagainst builds ofscratch-storageafter #20 was merged.Proposed Changes
The distinct entry point used by the web build,
index-web.js, has been removed. Instead, the web build uses the sameindex.jsentry point used by the Node build.One side effect is that the storage module will no longer be available by
window.Scratch.Storagewhendist/web/scratch-storage.jsis included on a web page through a<script>tag or similar. Instead, it will now be available throughwindow.ScratchStorage. This should not affect any of our internal Scratch 3.0 projects.Reason for Changes
This change should have been included with #20: that change broke the new scratch-gui integration tests. Roughly speaking this is because the
index-web.jsfile was doing a poor imitation of UMD, which conflicts with the proper use of UMD introduced in #20.