docs: close-out CC-203 / CC-247 / CC-248 — harness adoption complete (22/23)#153
Merged
Conversation
…e (22/23) + format/fail-fast options + consumer adoption CC-247 + CC-248 (th_init --format=<preset> + --fail-fast harness options) shipped in PR #142 on 2026-05-23 but BACKLOG status was never flipped. Final consumer adoption verified post PR-B.2 v2 (#152) close-out: - 4 of 10 migrated consumers select a non-default --format preset - 3 of 4 fail-fast consumers use --fail-fast (test-skill-refine, test-usage-tracker, test-usage-weekly) - grep '^(pass|fail)()' scripts/test-*.sh returns 0 (no per-file print-format or fail() overrides remain) CC-203 (shared scripts/lib/test-harness.sh) reaches its closure threshold at 22/23 test-*.sh adoption. The lone non-adopter is the orchestrator scripts/test-run-all-tests.sh which runs other test-*.sh as subprocesses and asserts on aggregated output — not a case-based harness fit; deliberately excluded per the GROUP-B re-analysis. The 3 files excluded from PR-B.2 v2's assert_* migration (CC-256) are on a separate axis and do not block CC-203 closure. Index + body sections updated for all 3 tickets with Outcome / See blocks. Validator-neutral edit (30 → 29 E-codes — opportunistically cleared CC-203 invalid area enum `ops/test/reuse` → `ops/test` as part of the row touch).
5 tasks
screenleon
added a commit
that referenced
this pull request
May 24, 2026
…err noise gone) (#154) * fix(cc-257): escape backticks in pr-gate.sh codex-brief heredocs (stderr noise gone) Every /pr-gate invocation emitted 7 `final::` / `**Final::` / `Final::` command-not-found errors at scripts/pr-gate.sh:362 (BRIEF_EOF heredoc opening line). Same 3-line block also lived in the synthesis brief heredoc (SBRIEF_P2). Root cause: unquoted heredoc delimiter → bash performed command substitution on the 7 backticked `Final:`/`final:` tokens that CC-252 (#147) added as cautionary examples ("DO NOT emit `**Final: GO**` etc."). Fix: escape the 7 backtick pairs (` → \`) in 3 unique lines that appear in both BRIEF_EOF (lines 451/452/467) and SBRIEF_P2 (lines 839/840/860). Bash now writes the backticks literally; brief content unchanged from codex's perspective — the cautionary tokens still render as backticked code in markdown. Considered Option A (quote the heredoc delimiter `<< 'BRIEF_EOF'`) but rejected: would have required pre-substituting 12 `${VAR}` references + `$(date)` — a much larger refactor for the same functional outcome. Option B (escape backticks) is a 6-line surgical edit. Regression test added at scripts/test-pr-gate.sh:: test_brief_construction_emits_no_shell_errors — invokes run_gate with CODEX_GATE_CAPTURE_BRIEF set, asserts stderr file does NOT contain "command not found" AND the captured brief still carries the cautionary tokens (verifies fix without losing the warning). Local verification: - test-pr-gate.sh 48/48 (was 47, +1 from new regression case) - test-test-harness.sh 30/30 - lint-scripts 52 files OK - Validator-neutral (29 → 29 E-codes; CC-203 area fix already in origin/main via PR #153) CC-257 row + body section flipped to ✅ closed 2026-05-24 with Outcome + See blocks. * docs(cc-257): tail commit — update pr:TBD → pr:#154
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docs-only close-out for 3 stale-active reuse-debt tickets. Code shipped in earlier PRs (#127 / #128 / #135-#140 / #142 / #152) but BACKLOG status was never flipped.
th_init --format=<preset>✅ closed 2026-05-23 — shipped in PR feat(cc-247,cc-248): th_init --format=<preset> + --fail-fast harness options #142; consumer adoption finalized in refactor(cc-249): PR-B.2 v2 — consumer migration to unified assert_* helpers (3 batches, 10 files) #152 (4 of 10 migrated consumers select non-default presets, 6 use defaultcolon-flat, zero per-filepass()/fail()overrides remain)th_init --fail-fast✅ closed 2026-05-23 — shipped in PR feat(cc-247,cc-248): th_init --format=<preset> + --fail-fast harness options #142; 3 fail-fast consumers (test-skill-refine, test-usage-tracker, test-usage-weekly) adopted in refactor(cc-249): PR-B.2 v2 — consumer migration to unified assert_* helpers (3 batches, 10 files) #152scripts/lib/test-harness.sh✅ closed 2026-05-24 — 22 of 23scripts/test-*.shadopt the harness; the lone non-adopter is the orchestratortest-run-all-tests.sh(runs othertest-*.shas subprocesses; deliberately excluded per the GROUP-B re-analysis as non-case-based). The 3 files excluded from PR-B.2 v2'sassert_*migration carry forward as CC-256 on a separate axis.Each ticket gets an
**Outcome**+**See**block in its body section.Validator impact
30 → 29 E-codes (BACKLOG.md). Opportunistically cleared
E-AREA-ENUM: CC-203 invalid area: ops/test/reuse→ops/testwhile touching the row (per[[validator-dryrun-before-strengthen]]pattern: data prep tagging along with the close-out edit). Other 29 baseline errors unchanged.Test plan
bash pm/scripts/validate.sh BACKLOG.md DECISIONS.md CHANGELOG.md— 29 E-codes (down from 30 baseline, 1 cleared)git diff --stat origin/main..HEADshows BACKLOG.md onlygrep -lE '^(pass|fail)\(\)' scripts/test-*.shreturns zero (CC-247/248 acceptance)scripts/test-*.shuseth_init(CC-203 acceptance) — sole non-adopter is the orchestrator90a600a feat(cc-247,cc-248): th_init --format=<preset> + --fail-fast harness options (#142)provides both optionsGate skipped per
[[gate-architecture-not-data]]— pure BACKLOG.md data commit, validator-neutral (improving), no code path touched.🤖 Generated with Claude Code