New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspector config hooks #26

Merged
merged 1 commit into from Dec 14, 2018

Conversation

Projects
None yet
3 participants
@laverdet
Copy link
Contributor

laverdet commented Apr 11, 2018

I wrote a mod that enables the v8 inspector in isolates but I needed some config hooks to get it done.

There's another change to create as well.. There was a race condition here if that function was called more than once before the first one was done completing. This would end up creating multiple isolates for the same user before the first one was initialized. So instead if you call the function more than once it will just return a promise to the previous not yet initialized isolate.

The mod is here: https://github.com/laverdet/screepsmod-inspector

@artch

This comment has been minimized.

Copy link
Contributor

artch commented Apr 13, 2018

Have you seen this race condition ever happening? It should never be the case, since the same user is not supposed to be executed in two threads simultaneously.

@laverdet

This comment has been minimized.

Copy link
Contributor

laverdet commented Apr 13, 2018

It happened for the source keepers, flooded the logs until I put the promise workaround in place.

@Ramblurr

This comment has been minimized.

Copy link

Ramblurr commented May 3, 2018

Looks like this patch needs to be rebased

@laverdet laverdet force-pushed the laverdet:isolated-vm branch from 4adc911 to 06ee389 May 17, 2018

@laverdet laverdet changed the base branch from isolated-vm to master May 17, 2018

@artch

This comment has been minimized.

Copy link
Contributor

artch commented Dec 10, 2018

Merged to ptr branch. It will be merged to master in a few days, so this PR can still remain open.

@artch artch added the ptr-staging label Dec 11, 2018

@artch artch merged commit 06ee389 into screeps:master Dec 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment