/engine

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow `swampCost` and `plainCost` as options in _findPath2 #62

Merged
merged 2 commits into from Feb 9, 2018

Conversation

Reviewers

@PostCrafter PostCrafter

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
3 participants
@tedivm @artch @PostCrafter
@tedivm
Contributor

tedivm commented Oct 18, 2017

Right now the only way to change the swamp and plain cost is ignoreRoads, but that doesn’t allow explicit control.

Adding this in _findPath2 will enable it in a variety of areas, including moveTo.
@tedivm
Allow `swampCost` and `plainCost` as options in _findPath2 
Right now the only way to change the swamp and plain cost is
`ignoreRoads`, but that doesn’t allow explicit control.

Adding this in `_findPath2` will enable it in a variety of areas,
including `moveTo`.
5c9a876
@PostCrafter

PostCrafter approved these changes Oct 18, 2017
View changes

@PostCrafter

PostCrafter approved these changes Oct 19, 2017
View changes

Can't believe I missed that...

@artch

This comment has been minimized.

Sign in to view
Contributor

artch commented Jan 1, 2018

Please rebase this to the ptr branch. It will be included in the next PTR patch.

@artch artch added the ptr-staging label Jan 1, 2018

@tedivm

This comment has been minimized.

Sign in to view
Contributor

tedivm commented Jan 1, 2018

Rebased.
@artch

This comment has been minimized.

Sign in to view
Contributor

artch commented Jan 2, 2018

The base branch of this PR has to be changed to ptr as well, see here.

@tedivm tedivm changed the base branch from master to ptr Jan 2, 2018

@tedivm

This comment has been minimized.

Sign in to view
Contributor

tedivm commented Jan 2, 2018

Base branch is now changed on both of my PRs.
@artch

This comment has been minimized.

Sign in to view
Contributor

artch commented Jan 3, 2018 •
edited

There is something wrong in the commits list and PR diff - there are unneccessary changes left from rebasing. Could you please clean it up so that it displays only actual changes?

@tedivm tedivm force-pushed the tedivm:set_terrain_costs branch from cda39b0 to e64f60a Jan 3, 2018

@tedivm

This comment has been minimized.

Sign in to view
Contributor

tedivm commented Jan 3, 2018

Fixed.
@artch

This comment has been minimized.

Sign in to view
Contributor

artch commented Jan 3, 2018

Thanks! Now we'll wait for other ptr-staging PRs (#61, #67 and #68) before deploying a new PTR patch.

@artch artch merged commit ffbc82c into screeps:ptr Feb 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment