Skip to content

Allow swampCost and plainCost as options in _findPath2 - #62

Merged
artch merged 2 commits into
screeps:ptrfrom
tedivm:set_terrain_costs
Feb 9, 2018
Merged

artch merged 2 commits into
screeps:ptrfrom
tedivm:set_terrain_costs

Conversation

@tedivm

@tedivm tedivm commented Oct 18, 2017

Copy link
Copy Markdown
Contributor

Right now the only way to change the swamp and plain cost is ignoreRoads, but that doesn’t allow explicit control.

Adding this in _findPath2 will enable it in a variety of areas, including moveTo.

Right now the only way to change the swamp and plain cost is
`ignoreRoads`, but that doesn’t allow explicit control.

Adding this in `_findPath2` will enable it in a variety of areas,
including `moveTo`.

@RiftLurker RiftLurker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't believe I missed that...

@artch

artch commented Jan 1, 2018

Copy link
Copy Markdown
Contributor

Please rebase this to the ptr branch. It will be included in the next PTR patch.

@tedivm

tedivm commented Jan 1, 2018

Copy link
Copy Markdown
Contributor Author

Rebased.

@artch

artch commented Jan 2, 2018

Copy link
Copy Markdown
Contributor

The base branch of this PR has to be changed to ptr as well, see here.

@tedivm
tedivm changed the base branch from master to ptr January 2, 2018 19:48
@tedivm

tedivm commented Jan 2, 2018

Copy link
Copy Markdown
Contributor Author

Base branch is now changed on both of my PRs.

@artch

artch commented Jan 3, 2018 •

Copy link
Copy Markdown
Contributor

There is something wrong in the commits list and PR diff - there are unneccessary changes left from rebasing. Could you please clean it up so that it displays only actual changes?

@tedivm
tedivm force-pushed the set_terrain_costs branch from cda39b0 to e64f60a Compare January 3, 2018 07:49
@tedivm

tedivm commented Jan 3, 2018

Copy link
Copy Markdown
Contributor Author

Fixed.

@artch

artch commented Jan 3, 2018

Copy link
Copy Markdown
Contributor

Thanks! Now we'll wait for other ptr-staging PRs (#61, #67 and #68) before deploying a new PTR patch.

@artch
artch merged commit ffbc82c into screeps:ptr Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants