Tombstone implementation

[AlinaNova21]

Engine side of tombstone implementation. Forum Discussion
A tombstone is generated when creeps die (Via any death method, ttl, suicide, etc)

New RoomObject->Tombstone class with properties: id, room, pos, owner, creepId, creep, store, deathTime, ticksToDecay.

Done

New constant TOMBSTONE_DECAY_PER_PART: 5. Decay time is set to creep.body.length * TOMBSTONE_DECAY_PER_PART

Needs constants updated. (Should I PR screeps/common for this?)

When decayed, resources are dropped on the ground.

Working

Vision is provided.

As far as I can tell, this needs a driver/runtime update, do I need to write a PR for that?
Vision is working automatically.

Find and look constants are also implemented.

Test Cases I'm testing with:

• Decays after TOMBSTONE_DECAY_PER_PART * body.length
• Death:
  • Suicide
  • Damage
  • TTL
• Resources:
  • Resources go into container if it exists and will fit, excess goes into tombstone
  • Drops resources on ground upon decay regardless of presence of container
  • Boosts drop correctly
  • One-shot killed creeps with CARRY also drop into tombstone
• Userland Properties:
  • deathTime
    • creep:
      • id
      • name
      • body
      • ticksToLive
      • saying
        • Only set if last say was public

For the rendering and constants, I'm using a tiny mod for testing

// Change a global constant

module.exports = function (config) {
    if(config.common) {
        config.common.constants.FIND_TOMBSTONES = 200
        config.common.constants.LOOK_TOMBSTONES = 'tombstone'
        config.common.constants.TOMBSTONE_DECAY_PER_PART = 5
    }

    if(config.backend) {
      // Add visuals
      config.backend.customObjectTypes.tombstone = { 
        // Only renders with Legacy SVG in client
        svg: `<g>
            <ellipse cx="0" cy="0" rx="30" ry="30" fill="#555555"></ellipse>
            <rect x="-30" y="0" width="60" height="40" fill="#555555"></rect>
            <text x="0" y="20" font-size="32" stroke="black" fill="white" text-anchor="middle">RIP</text>
            </g>`,
        sidepanel: `
          <div><label>Creep ID:</label><span>{{object.creepId}}</span></div>
          <div><label>Death Time:</label><span>{{object.deathTime}}</span></div>
          <div><label>Ticks To Decay:</label><span>{{object.decayTime - Room.gameTime}}</span></div>
          <div class='body'>
          <label class='body-header'>
          Store
          <div class='pull-right'>
          {{Room.calcResources(Room.selectedObject) | round}}
          </div>
          </label>
          <div ng:if='!Room.calcResources(Room.selectedObject)'>Empty</div>
          <table class='carry-resource'>
          <tr ng-if='Room.selectedObject[resourceType]' ng:repeat='resourceType in Room.Constants.RESOURCES_ALL'>
          <td>{{Room.selectedObject[resourceType] | number}}&nbsp;&times;&nbsp;</td>
          <td>
          <img class='resource-type' ng-src='https://s3.amazonaws.com/static.screeps.com/upload/mineral-icons/{{resourceType}}.png' tooltip='{{Room.resourceTypeNames[resourceType]}}'>
          </td>
          </tr>
          </table>
          </div>
        `
      }
      }
    }
};

[artch]

Great job!

As for vision, could you please test it? It may work automatically, since it has user property in the DB.

[RiftLurker]

LGTM

[DissiNL]

Will tombstones be part of the OBSTACLE_OBJECT_TYPES? Now they're walk-able.

[AlinaNova21]

Can confirm, vision is working automatically.

[artch]

This doesn't look good.

[AlinaNova21]

Missed that, removed

[artch]

There is no need to store creep's hits, it seems to be always 0 since the creep is dead, right? Also, body[].hits is all 0 too, so we can store body in plain format ['move','move','work',...] (but expose to user in normal Creep.body format).

[AlinaNova21]

is hits 0 when a creep dies by TTL?

[AlinaNova21]

Thinking about it, people can use TTL to determine cause of death, TTL would be 0 on age death, suicides are user triggered, and death from damage would leave a positive TTL

[artch]

x, y, and room are the same as in the tombstone, no need to store them.

[AlinaNova21]

Those are the tombstone x, y, and room

[AlinaNova21]

@ButAds: Will tombstones be part of the OBSTACLE_OBJECT_TYPES? Now they're walk-able.

I don't think they should, they currently stack while in existence, one for each creep that has died on that tile. If they were obstacles, it would be easy to effectively blockade areas just by spamming creeps and suicide

[DissiNL]

I agree! Just wanted to make sure

[RiftLurker]

Right now this will add to the creepsLost stat, which isn't exactly what you want.
Using undefined instead of stats will fix this already, but maybe it's better to add options to disable this behaviour?

[AlinaNova21]

hmm, IIRC, somewhere else it also passes undefined as stats, updating now

[AlinaNova21]

its spawn recycle-creep where it passes undefined

[RiftLurker]

Code looks good to me, going to test it later on.

[RiftLurker]

Tested with all of the above use cases, everything seems to work fine.