Tombstone implementation by AlinaNova21 · Pull Request #74 · screeps/engine

AlinaNova21 · 2018-01-23T18:19:30Z

Engine side of tombstone implementation. Forum Discussion
A tombstone is generated when creeps die (Via any death method, ttl, suicide, etc)

New RoomObject->Tombstone class with properties: id, room, pos, owner, ~~creepId~~, creep, store, deathTime, ticksToDecay.

Done

New constant TOMBSTONE_DECAY_PER_PART: 5. Decay time is set to creep.body.length * TOMBSTONE_DECAY_PER_PART

Needs constants updated. (Should I PR screeps/common for this?)

When decayed, resources are dropped on the ground.

Working

Vision is provided.

~~As far as I can tell, this needs a driver/runtime update, do I need to write a PR for that?~~
Vision is working automatically.

Find and look constants are also implemented.

Test Cases I'm testing with:

For the rendering and constants, I'm using a tiny mod for testing

// Change a global constant

module.exports = function (config) {
    if(config.common) {
        config.common.constants.FIND_TOMBSTONES = 200
        config.common.constants.LOOK_TOMBSTONES = 'tombstone'
        config.common.constants.TOMBSTONE_DECAY_PER_PART = 5
    }

    if(config.backend) {
      // Add visuals
      config.backend.customObjectTypes.tombstone = { 
        // Only renders with Legacy SVG in client
        svg: `<g>
            <ellipse cx="0" cy="0" rx="30" ry="30" fill="#555555"></ellipse>
            <rect x="-30" y="0" width="60" height="40" fill="#555555"></rect>
            <text x="0" y="20" font-size="32" stroke="black" fill="white" text-anchor="middle">RIP</text>
            </g>`,
        sidepanel: `
          <div><label>Creep ID:</label><span>{{object.creepId}}</span></div>
          <div><label>Death Time:</label><span>{{object.deathTime}}</span></div>
          <div><label>Ticks To Decay:</label><span>{{object.decayTime - Room.gameTime}}</span></div>
          <div class='body'>
          <label class='body-header'>
          Store
          <div class='pull-right'>
          {{Room.calcResources(Room.selectedObject) | round}}
          </div>
          </label>
          <div ng:if='!Room.calcResources(Room.selectedObject)'>Empty</div>
          <table class='carry-resource'>
          <tr ng-if='Room.selectedObject[resourceType]' ng:repeat='resourceType in Room.Constants.RESOURCES_ALL'>
          <td>{{Room.selectedObject[resourceType] | number}}&nbsp;&times;&nbsp;</td>
          <td>
          <img class='resource-type' ng-src='https://s3.amazonaws.com/static.screeps.com/upload/mineral-icons/{{resourceType}}.png' tooltip='{{Room.resourceTypeNames[resourceType]}}'>
          </td>
          </tr>
          </table>
          </div>
        `
      }
      }
    }
};

Now matches the [simultaneous action documentation](http://docs.screeps.com/simultaneous-actions.html). Prior to this change creeps would be able to use `attackController` and `heal`/`rangedHeal` in the same tick.

artch · 2018-01-24T08:59:31Z

Great job!

As for vision, could you please test it? It may work automatically, since it has user property in the DB.

RiftLurker

LGTM

DissiNL · 2018-01-24T12:52:53Z

Will tombstones be part of the OBSTACLE_OBJECT_TYPES? Now they're walk-able.

AlinaNova21 · 2018-01-24T14:10:03Z

Can confirm, vision is working automatically.

artch · 2018-01-24T15:08:50Z

        });
    }

+    if(container) bulk.upda


This doesn't look good.

Missed that, removed

artch · 2018-01-24T15:11:51Z

+        creepBody: object.body,
+        creepAgeTime: object.ageTime,
+        creepBody: object.body,
+        creepHits: object.hits,


There is no need to store creep's hits, it seems to be always 0 since the creep is dead, right? Also, body[].hits is all 0 too, so we can store body in plain format ['move','move','work',...] (but expose to user in normal Creep.body format).

is hits 0 when a creep dies by TTL?

Thinking about it, people can use TTL to determine cause of death, TTL would be 0 on age death, suicides are user triggered, and death from damage would leave a positive TTL

artch · 2018-01-24T15:12:10Z

+        type: 'tombstone',
+        room: object.room,
+        x: object.x,
+        y: object.y,


x, y, and room are the same as in the tombstone, no need to store them.

Those are the tombstone x, y, and room

AlinaNova21 · 2018-01-24T15:40:33Z

@ButAds: Will tombstones be part of the OBSTACLE_OBJECT_TYPES? Now they're walk-able.

I don't think they should, they currently stack while in existence, one for each creep that has died on that tile. If they were obstacles, it would be easy to effectively blockade areas just by spamming creeps and suicide

DissiNL · 2018-01-24T15:45:19Z

I agree! Just wanted to make sure

…ts) is placed in tombstone

RiftLurker · 2018-01-26T15:34:29Z

-
-                bulk.remove(object._id);
-                delete roomObjects[object._id];
+                require('./_die')(object, roomObjects, bulk, stats, undefined, gameTime);


Right now this will add to the creepsLost stat, which isn't exactly what you want.
Using undefined instead of stats will fix this already, but maybe it's better to add options to disable this behaviour?

hmm, IIRC, somewhere else it also passes undefined as stats, updating now

its spawn recycle-creep where it passes undefined

RiftLurker · 2018-01-26T15:39:29Z

Code looks good to me, going to test it later on.

This allows tombstones to contain the creep's last words

RiftLurker · 2018-01-27T12:22:15Z

Tested with all of the above use cases, everything seems to work fine.

…131-tombstone

This reverts commit ba7795e.

* Tombstone implementation * Fixed new creeps auto-killing on blcoked spawns and recylcing * Drop to container * Adjust tombstones to use a stub creep * Only store body types, removed duplicate creepBody, fix TTL saving * Fixed syntax error and hitsMax * Fixed containers being overfilled * Adjusted so that any energy that won't fit into container (if it exists) is placed in tombstone * Fix Tombstones to never drop into containers when decayed. * Fix saving public say to tombstone * Fixed tombstone not spawning for TTL deaths * Tombstones: Don't pass stats to _die for TTL death * Allow creep say intent to be processed before the suicide intent This allows tombstones to contain the creep's last words * small fixes * remove `owner` and `my`

RiftLurker and others added 8 commits January 1, 2018 13:07

Fix simultaneous execution of attackController (screeps#70)

54d1039

Now matches the [simultaneous action documentation](http://docs.screeps.com/simultaneous-actions.html). Prior to this change creeps would be able to use `attackController` and `heal`/`rangedHeal` in the same tick.

feat(runtime): isolated-vm integration

e9aaba6

feat(runtime): isolated-vm integration

66f1714

feat(runtime): isolated-vm integration

ee3e9a2

feat(runtime): isolated-vm integration

5e5aea3

feat(runtime): isolated-vm integration

89bbcab

Tombstone implementation

b997a3d

Fixed new creeps auto-killing on blcoked spawns and recylcing

b78f101

RiftLurker approved these changes Jan 24, 2018

View reviewed changes

AlinaNova21 added 2 commits January 24, 2018 08:26

Drop to container

ef1b319

Adjust tombstones to use a stub creep

63673b2

artch requested changes Jan 24, 2018

View reviewed changes

artch added the ptr-staging label Jan 24, 2018

AlinaNova21 added 2 commits January 24, 2018 09:23

Only store body types, removed duplicate creepBody, fix TTL saving

17b65a6

Fixed syntax error and hitsMax

55cce7c

AlinaNova21 added 2 commits January 24, 2018 10:38

Fixed containers being overfilled

6e552a3

Adjusted so that any energy that won't fit into container (if it exis…

a8a4bc4

…ts) is placed in tombstone

artch changed the base branch from master to ptr January 24, 2018 20:17

AlinaNova21 mentioned this pull request Jan 24, 2018

Add Tombstone screeps/docs#82

Merged

AlinaNova21 added 3 commits January 24, 2018 18:32

Fix Tombstones to never drop into containers when decayed.

dc951b0

Fix saving public say to tombstone

55838d0

Fixed tombstone not spawning for TTL deaths

95194bd

RiftLurker suggested changes Jan 26, 2018

View reviewed changes

Tombstones: Don't pass stats to _die for TTL death

53cd12b

RiftLurker approved these changes Jan 26, 2018

View reviewed changes

Allow creep say intent to be processed before the suicide intent

3765726

This allows tombstones to contain the creep's last words

artch added 2 commits January 31, 2018 10:58

Merge branch 'tombstone' of https://github.com/ags131/engine into ags…

a1bdabe

…131-tombstone

small fixes

63feb7c

artch merged commit ba7795e into screeps:ptr Jan 31, 2018

artch added a commit that referenced this pull request Jan 31, 2018

Revert "feat: Tombstones (#74)"

a392c29

This reverts commit ba7795e.

Uh oh!

Conversation

AlinaNova21 commented Jan 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

artch commented Jan 24, 2018

Uh oh!

RiftLurker left a comment

Choose a reason for hiding this comment

Uh oh!

DissiNL commented Jan 24, 2018

Uh oh!

AlinaNova21 commented Jan 24, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

artch Jan 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlinaNova21 commented Jan 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DissiNL commented Jan 24, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RiftLurker commented Jan 26, 2018

Uh oh!

RiftLurker commented Jan 27, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AlinaNova21 commented Jan 23, 2018 •

edited

Loading

artch Jan 24, 2018 •

edited

Loading

AlinaNova21 commented Jan 24, 2018 •

edited

Loading