Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add CONTRIBUTING guide #33

Merged
merged 1 commit into from Mar 1, 2017
Merged

chore: Add CONTRIBUTING guide #33

merged 1 commit into from Mar 1, 2017

Conversation

r3rastogi
Copy link
Contributor

No description provided.

Copy link
Contributor

@FenrirUnbound FenrirUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Looks fine to me. You may want to check with someone who worked on the semantic-release automation to see if chore will publish a new release.

@@ -40,11 +40,12 @@ To be consistent, we require commit messages to be in this specific format: `<ty
* test (when adding missing tests)
* chore (maintain)
* Scope: anything that specifies the scope of the commit. Can be blank or `*`
* If your commit addresses a specific issue, include the number after the type
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Maybe include a link to all issues (https://github.com/screwdriver-cd/screwdriver/issues)

Copy link
Contributor

@petey petey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this doc say something about a description in the commit?

Copy link
Member

@tkyi tkyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ^^what Petey said
  • Small comment but it isn't necessary to get this PR merged
    👍

Copy link
Member

@minzcmu minzcmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 and i think we can addresses the small comments in another PR

@minzcmu minzcmu merged commit e1121b3 into master Mar 1, 2017
@minzcmu minzcmu deleted the contributing branch March 1, 2017 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants