New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add CONTRIBUTING guide #33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Looks fine to me. You may want to check with someone who worked on the semantic-release
automation to see if chore
will publish a new release.
@@ -40,11 +40,12 @@ To be consistent, we require commit messages to be in this specific format: `<ty | |||
* test (when adding missing tests) | |||
* chore (maintain) | |||
* Scope: anything that specifies the scope of the commit. Can be blank or `*` | |||
* If your commit addresses a specific issue, include the number after the type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Maybe include a link to all issues (https://github.com/screwdriver-cd/screwdriver/issues)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this doc say something about a description in the commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 and i think we can addresses the small comments in another PR
No description provided.