Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow builds to tag event #939

Closed
jithine opened this issue Mar 22, 2018 · 5 comments
Closed

Allow builds to tag event #939

jithine opened this issue Mar 22, 2018 · 5 comments
Assignees
Projects

Comments

@jithine
Copy link
Member

jithine commented Mar 22, 2018

Context

In a pipeline events page GIT SHA and commit message is what uniquely identifies an event. It would be helpful for users to quickly identify an event using a key->value pair which a build can set to identify a specific event rather than going through the SHA and commit message.

For example a build in a release pipeline can set value RELEASE_VERSION=1.5.1 to identify an event which built Version 1.5.1 and use that to quickly identify the event. In a roll back scenario this helps users to quickly identify the event from which they need to invoke roll back.

Objective

  1. Expose a mechanism for builds to tag event.
    1. It can be an entry in meta
  2. UI should display the tag for the event.
@jithine jithine created this issue from a note in Active Work (Backlog) Mar 22, 2018
@drewfish
Copy link

How is this different than git tags?

@jithine
Copy link
Member Author

jithine commented Mar 29, 2019

How is this different than git tags?

value can be same as git tag. Feature is about surfacing that value in UI so that someone who wants to do a roll back can quickly identify which event to select.

@tkyi
Copy link
Member

tkyi commented Apr 3, 2019

Wondering if this is the right way to go about providing a solution for identifying events. From this proposal, a tag/label can only be set through meta.
There are times when I might rerun a build without making any code changes and I would want to label that event with a different label (e.g. if it's pulling in different npm package versions compared to the last one). If the label is only set through meta, changing the label might only be possible by starting the event through the API.

@jithine
Copy link
Member Author

jithine commented Apr 3, 2019

There are times when I might rerun a build without making any code changes and I would want to label that event with a different label (e.g. if it's pulling in different npm package versions compared to the last one). If the label is only set through meta, changing the label might only be possible by starting the event through the API.

That's a good point. We can do this when we get to #1339
Since re-run is creating a new event, mechanism will be same.

@tkyi tkyi added the ui label Apr 5, 2019
@tkyi tkyi moved this from Doing to Verify in Active Work Apr 5, 2019
@tkyi tkyi moved this from Verify to Doing in Active Work Apr 5, 2019
@tkyi tkyi moved this from Doing to Verify in Active Work Apr 5, 2019
@jithine jithine closed this as completed Apr 9, 2019
@jithine jithine moved this from Verify to Done in Active Work Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

3 participants