fix: add path-style URL switch flag for S3 strategy. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkyi
approved these changes
Feb 12, 2018
FenrirUnbound
approved these changes
Feb 12, 2018
|
In addition, I've created a PR to push this upstream to the |
|
Looks like @FenrirUnbound's PR was merged and the change was released. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
S3 storage strategy (catbox-s3) supports virtual-hosted-style URL by default and does not provide a flag to use path-style URL.
Objective
This PR adds path-style URL switch flag and makes it possible for users to use a S3 compatible server (that supports path-style only, e.g. Minio) easily.
References