Skip to content

[SERF-3091] Drop Terraform support lower than 1.0 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
terranisu merged 4 commits into from
Jan 4, 2024
Merged

[SERF-3091] Drop Terraform support lower than 1.0 #20

terranisu merged 4 commits into from
Jan 4, 2024

Conversation

@terranisu
Copy link
Member

@terranisu terranisu commented Jan 3, 2024 •
edited
Loading

Description

The PR drops Terraform (TF) support lower than 1.0, namely:

  • Bumps the min TF version to v1.0.0
  • It updates the deployment pipeline to stop checking the configuration against TF 0.13.x, 0.14.x

Note: A new major version will be released as the PR contains breaking change.

Testing considerations

The pipelines are green.

Checklist

  • Prefixed the PR title with the JIRA ticket code
  • Performed simple, atomic commits with good commit messages
  • Verified that the commit history is linear and commits are squashed as necessary
  • Thoroughly tested the changes in development and/or staging
  • Updated the README.md as necessary

Related links

@terranisu terranisu self-assigned this Jan 3, 2024
@terranisu terranisu requested a review from a team as a code owner January 3, 2024 11:34
@terranisu terranisu requested a review from laynax January 3, 2024 11:34
@terranisu terranisu marked this pull request as draft January 3, 2024 11:34
@terranisu terranisu marked this pull request as ready for review January 3, 2024 11:37
Neurostep
Neurostep approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@Neurostep Neurostep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

laynax
laynax approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@laynax laynax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terranisu terranisu merged commit c8db42d into main Jan 4, 2024
@terranisu terranisu deleted the vadimka/drop-tf-support-lower-than-1.0 branch January 4, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Neurostep Neurostep Neurostep approved these changes

@fotos fotos Awaiting requested review from fotos

@basmscribd basmscribd Awaiting requested review from basmscribd

@helenff helenff Awaiting requested review from helenff

+1 more reviewer

@laynax laynax laynax approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@terranisu terranisu

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@terranisu @Neurostep @laynax