Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third-party licenses menu tab in about section #319

Closed
2 tasks done
andrewtavis opened this issue May 21, 2023 · 5 comments
Closed
2 tasks done

Third-party licenses menu tab in about section #319

andrewtavis opened this issue May 21, 2023 · 5 comments
Assignees
Labels
feature New feature or request GSoC Available for Google Summer of Code participants help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

Terms

Description

This issue is to create a screen in the new Scribe menu that's being developed in #16 that would display a list of third party software that was used in the development of Scribe to the user upon navigating there from the about tab. Designs for this screen can be found in the designs on Figma. The screen can generally be the same as the current privacy policy with a document checkmark icon in the top right. What software to include and whether to include their full licenses should be considered, but generally I'd argue that how it's set up in the designs should be fine. I think that including our dependencies as well might make sense :)

Contribution

This issue is included in Google Summer of Code 2023 ☀️🚀 Am here to help with the licenses and discuss if we need to add more information to the list!

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed blocked Another issue is blocking GSoC Available for Google Summer of Code participants labels May 21, 2023
@andrewtavis andrewtavis removed the blocked Another issue is blocking label Jun 12, 2023
@SaurabhJamadagni
Copy link
Collaborator

Hey @andrewtavis, for the texts for this issue and #318, should I use google translate for the german texts? Or should I leave it open to contribution for someone to add proper texts? As licenses is something legal I don't know if google translate would provide an accurate translation. So wanted your opinion on this one. 😅

@andrewtavis
Copy link
Member Author

Hey @SaurabhJamadagni! We’ll just have a section at the top that says that the English version is binding as with the privacy policy, so no stress :) I’m happy to do the German translation though! Let’s check in in the Weekly and I’ll make a task/issue for next week :)

@SaurabhJamadagni
Copy link
Collaborator

Hey @andrewtavis! Need your opinion on what's the better implementation. I was trying to solve the text being overlapped with the corner image problem.

  • The first option is to change the Z-order so that the text sits above the image: This results in something like this:
image

But in most cases it is normal:
image

It is more prominant on iPad:
image

  • Another option is to add newlines before the first sentence, but then that leaves a lot of whitespace behind:
    For example, the iPad case:
image

And the iPhone case:
image

Should I push it with the newline? You could check if the whitespace is too much better running it locally. I don't think the images are giving the right proportions.

@andrewtavis
Copy link
Member Author

With the new line would definitely be preferable, @SaurabhJamadagni :) Thanks for checking!

@andrewtavis
Copy link
Member Author

Closed via #335! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request GSoC Available for Google Summer of Code participants help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

2 participants