Support for Constant Contact OAuth 2 #240

Merged
merged 3 commits into from Sep 4, 2012

Conversation

Projects
None yet
3 participants
Contributor

matthewdlaudato commented Mar 29, 2012

Pablo, I've added the basic support for using our recently added OAuth 2 support. Please review and pull the code into master.

Best,

  • Matt
Collaborator

fernandezpablo85 commented Mar 30, 2012

Please check the code style (indentation, opening braces in the next line and imports with *)

Contributor

matthewdlaudato commented Apr 5, 2012

I don't have any imports with * - are you saying that I should? That would seem to be bad style - you should import only what you need. I will look at the indents and braces. Are you using a particular format that I should be aware about (I can set Eclipse to do anything I want in that area.)

Contributor

matthewdlaudato commented Apr 5, 2012

Pablo, I updated the code style. Did not change the imports to * - see my earlier comment.

Collaborator

fernandezpablo85 commented Apr 6, 2012

Yes I use imports with stars (*). It's a matter of taste (you call it bad style, I call it good style).

If you don't mind, please change them. If not, but you still want the patch in, I can do it (not sure when though).

Contributor

matthewdlaudato commented Apr 6, 2012

Not a problem Pablo, I will change them. to each his own as they say.

  • Matt

Sent from my iPhone

On Apr 5, 2012, at 8:36 PM, Pablo Fernandezreply@reply.github.com wrote:

Yes I use imports with stars (*). It's a matter of taste (you call it bad style, I call it good style).

If you don't mind, please change them. If not, but you still want the patch in, I can do it (not sure when though).


Reply to this email directly or view it on GitHub:
fernandezpablo85#240 (comment)

hey matt, could you add an example class like the many others for completeness? thx
I've fetched your changes into my fork, I'm trying to get as many supported apis together as possible.

@fernandezpablo85 fernandezpablo85 merged commit 89d8db5 into scribejava:master Sep 4, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment