removed auth keys & secret keys from examples #245

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

philihp commented Apr 5, 2012

Hi,

I noticed there were some app IDs and secret keys in some examples, while other examples told the user to replace them. fixed this so it's "you should replace this" in all of them.

Collaborator

Though I like consistency, I think the whole "get something working out of the box" is useful. Perhaps there's a way to get the best of both worlds?

philihp commented Apr 5, 2012

I understand, I like that too, but I worry that a lazy or naive developer will just use your keys without understanding the implications of doing so. Some of the examples (such as the Facebook example) lack API keys, shall I find stub keys for those?

Collaborator

No, you're into something here. There are some good points:

  1. Some examples have a key and others don't, this distinction is arbitrary.

  2. Examples are sometimes used (by myself or others) as end-to-end tests, this is not right.

  3. Examples are pretty much the same thing, over and over.

philihp commented Apr 5, 2012

Perhaps there should be proper test cases (with keys) in one place, and there should be examples (without keys) in another place?

Collaborator

I was thinking something like that:

  1. end-to-end tests

  2. Wikipage with one or two examples

Collaborator

I've always wanted to create some (perhaps ruby-powered) end-to-end tests BTW

philihp commented Apr 5, 2012

How does one create ruby-powered tests? That sounds cool (I have always wanted an excuse to learn some Ruby), but I've never seen it done with anything other than JUnit.

Collaborator

I was thinking about some automation tool like watir for example. I do need to take some time off and draft something like that though. If you want to give it a look yourself, that would be super awesome :)

I'm open to ideas here, it doesn't need to be ruby at all.

philihp commented Apr 7, 2012

Oh man, yeah, doing this in JUnit is annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment