Add support for Withings #331

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@ejain
ejain commented Dec 1, 2012

No description provided.

@arwright

Wow. We were struggling and Eric's code here is exactly what we needed to fix our problem. Thanks Eric!

It looks like this pull request was accepted. I don't understand why these changes don't show up in the current version of scribe. We wouldn't have struggled as long if this were in the master tree instead of just tucked away in this pull request.

Collaborator

I don't understand why these changes don't show up in the current version of scribe

If you're talking about the Api, it should be on the source. If you're talking about the example, then it's not part of the library distribution (that's why it's on the "test" folder)

We wouldn't have struggled as long if this were in the master tree instead of just tucked away in this pull request.

I assume you read all the wikipages, specially the one that talks about custom apis (https://github.com/fernandezpablo85/scribe-java/wiki/Custom-Apis), right?

Collaborator

BTW I'm sorry to hear you struggled that long. That said, I try to reply to issues and emails within the hour and I never got one from you.

Hi Pablo,

Thanks for responding.

If you're talking about the Api, it should be on the source. If you're talking about the example, then it's not part of the library distribution (that's why it's on the "test" folder)

I assume you read all the wikipages, specially the one that talks about custom apis (https://github.com/fernandezpablo85/scribe-java/wiki/Custom-Apis), right?

We are actually using a local checkout of scribe-java which does contain the test folder and not a library distribution. We checked for Withings files in both the local checkout of src/main/java/org/scribe/builder/api and src/test/java/org/scribe/examples, as well as the corresponding api and test examples in the current head of the master branch on github. The relevant Withings support files (WithingsApi.java and WithingsExample.java) were not there.

We thought that this meant that Withings support had not yet been added to scribe-java. We created a local version, but were flailing trying to get it to work. Eric's WithingsExample.java file, once we stumbled upon it, provided the critical bit we were missing: the need to include .signatureType(SignatureType.QueryString) as part of creating the OAuthService.

Now that we know the right answer, I see that that call was indeed mentioned in the Custom-Apis page. We just didn't realize its relevance to the problems we were having with Withings until we saw it here in Eric's pull request.

BTW I'm sorry to hear you struggled that long. That said, I try to reply to issues and emails within the hour and I never got one from you.

I very much appreciate your responsiveness and willingness to help. We did not try to contact you on this issue because we felt that our difficulties reflected a problem with our understanding of how to apply scribe-java to an as-yet-unsupported service, not a problem with scribe-java itself. As it turns out, that feeling was correct. We just didn't know that there was already an example showing how to do it right was tucked away here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment