Update TwitterApi.java #455

Merged
merged 2 commits into from Jan 27, 2014

Conversation

Projects
None yet
3 participants
Contributor

robindrost commented Jan 27, 2014

  • Changed the request and access token endpoints to https.
  • Removed the inner SSL class since Twitter now forces to use https instead of http.
  • Removed the extend SSL from the Authenticate class since it no longer exists anymore.
Update TwitterApi.java
- Changed the request and access token endpoints to https.

- Removed the inner SSL class since Twitter now forces to use https instead of http.

- Removed the extend SSL from the Authenticate class since it no longer exists anymore.
*/
- public static class Authenticate extends SSL
+ public static class Authenticate
@fernandezpablo85

fernandezpablo85 Jan 27, 2014

Collaborator

This should extend TwitterApi. Note the build is failing.

Update TwitterApi.java
- Authenticate now extends the TwitterApi class so the @Override annotation is used correctly.

fernandezpablo85 added a commit that referenced this pull request Jan 27, 2014

@fernandezpablo85 fernandezpablo85 merged commit f70c628 into scribejava:master Jan 27, 2014

1 check passed

default The Travis CI build passed
Details

Thanks for fixing this! Looks like the latest release is 1.3.5 from 9 months ago which does not include this change... anyone know when a new release is going to be made that includes this?

It seems 1.3.5 is broken as Twitter now requires SSL and http://api.twitter.com/oauth/request_token is invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment