Add support for OpenID connect providers #646
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 18, 2016 17:56
- allow OpenID connect to be used as generic authentication mechanism; - allow OpenID configuration to be obtained from an external source to get a generic API.
- expanded the constants used in the OpenID connect discovery specification.
- made the configuration a simple POJO that should be filled by the user before creating the OpenIdConnectApi.
|
Oh.. Interesting... OpenId isnot the goal for ScribeJava, but in case it won't make using ScribeJava more difficult... Thanks for PR. Will think on it |
|
The reason I've done this is that OpenID connect bolts on top of OAuth2 and well supported by ScribeJava. It saves me from writing lots of boilerplate code with the APIs provided by ScribeJava ;) |
|
nice to hear, that ScribeJava helps ;-) |
|
I would love something like this to be merged into here, OIDC is well established by now and of great use. |
|
You're definitely right! I have some plans, but a lack of time is my enemy. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some basic support for working with OpenID connect providers, such as Google and Microsoft. In contrast to the existing APIs, I've chosen to make this API a little more flexible in the sense that you can provide it the exact configuration it should use. This configuration can be obtained, for example, through the OpenID connect discovery mechanism.
Although there are no tests in this PR, I've tested it in another project against both Google and Microsoft.