Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better HiRes support #20

Closed
wants to merge 1 commit into from

Conversation

@LiamHD
Copy link

commented Aug 15, 2015

Add basic HiRes support on Mac OS.

Add basic HiRes support on Mac OS.
@LiamHD

This comment has been minimized.

Copy link
Author

commented Aug 15, 2015

See the difference:
new_old

@luzpaz

This comment has been minimized.

Copy link

commented Aug 15, 2015

Hi @LiamHD
Help me understand the differences in the screenshot. I'm not picking up on them.

@LiamHD

This comment has been minimized.

Copy link
Author

commented Aug 15, 2015

@luzpaz
Just click on the screenshot (so that you see the full size version). You will see that the text on the left side is sharp compared to the text on the right side.

@luzpaz

This comment has been minimized.

Copy link

commented Aug 15, 2015

@LiamHD Great! I submitted patch to the scribus bugtracker http://bugs.scribus.net/view.php?id=13301

@luzpaz

This comment has been minimized.

Copy link

commented Aug 17, 2015

@LiamHD patch was committed upstream and now is in github mirror (156ebfd). Thanks for your PR!

@luzpaz luzpaz closed this Aug 17, 2015
@LiamHD

This comment has been minimized.

Copy link
Author

commented Aug 17, 2015

Thanks.
How often do you mirror from SVN to githup? Is this a manual process?

What's the best / easiest way if I want to contribute code and want to develop on my Macbook?
I would love to use the git repo (as I use git in all my other projects and don't know SVN). Is that possible?

@luzpaz

This comment has been minimized.

Copy link

commented Aug 17, 2015

@LiamHD we mirror it manually, at this point. @aoloe or myself will trigger the sync using a script that @chhitz created.

What's the best / easiest way if I want to contribute code and want to develop on my Macbook?

The main devs of Scribus prefer to use SVN. The workflow is to submit any bugs, patches via bugs.scribus.net and then those in turn are committed via SVN.
One of the main devs, Craig, uses OSX.

I would love to use the git repo (as I use git in all my other projects and don't know SVN). Is that possible?

I totally think so! What we would do is translate any of your PRs in to bugs.scribus.net like we did with this issue. It went fairly smooth though obviously not as ideal as approving a PR directly. This will work for now.

@LiamHD

This comment has been minimized.

Copy link
Author

commented Aug 17, 2015

So I would install the dependencies of scribus via homebrew and then clone the git repo?
Would I use XCode as IDE?

I looked around on your wiki but could not find something like a "getting started guide" for developers.

@aoloe

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2015

hi @LiamHD,

something still missing in our github workflow: how to mark the pull requests as accepted, even if we cannot apply them to the master... there must be a way :-)
if you can find it out for us, it would be a nice contribution.

for the IDE, the best one for scribus is probably Qt Craetor: http://wiki.qt.io/Category:Tools::QtCreator
it's provided by the company developing Qt, is not perfect, but imo rather good...

and concerning, the getting started guide, i have somewhere in my github account some notes about it :-) ... and there are older howtos in the wiki...

my notes are here:

and you're welcome to make pull requests against them (most of all against the https://github.com/aoloe/scribus-manual-development/tree/master/content directory where the content should go at the end of the process).

some ideas on the way i'd like to setup the content can be found here:

everything still in the starting blocks...

@LiamHD

This comment has been minimized.

Copy link
Author

commented Aug 18, 2015

regarding the github workflow.
Do you now that github repos can be cloned as svn repos? See https://github.com/blog/966-improved-subversion-client-support

@aoloe

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2015

hi @LiamHD , everything has been tried.

until the next stable version 1.6 comes out there is not much use in discussing a switch to git/github with the scribus team. (at least for what i am concerned :-)

until that (unknown) time (in the future) this github repository will be managed as a community repository and patches will be handed hover to the team by attaching them to tickets in the official bug tracker.
the topic has been discussed at length and, personally, i'm more than happy that we finally seem to be able to manage a community repository on github!
and the first pull requests are coming in!

the next step being: a way to accept pull requests so that contributors get rewarded with nice stats in their account!
(the step after that might be to apply patches to the community version, that are not in the trunk... but we don't have such patches to apply right now... so it's an hypothetical thing for now)

@aoloe

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2015

@LiamHD

This comment has been minimized.

Copy link
Author

commented Aug 19, 2015

Ok that's quite basic. I would like to see how the local development setup ideally looks like (on the various platforms). As I do not have any experience in developing Scribus (on any platform) I don't feel capable of contributing this.
As one of the main devs is developing on Mac OS maybe he can share how his setup looks like.

@luzpaz luzpaz referenced this pull request Oct 28, 2015
2 of 5 tasks complete
aoloe pushed a commit that referenced this pull request Jul 5, 2016
…as #2320 instead of #20

git-svn-id: svn://scribus.net/trunk/Scribus@21395 11d20701-8431-0410-a711-e3c959e3b870
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.