regarding tests

[smoothdeveloper]

I believe generic integration test sets could be written in such ways:

• partition midi file
• input midi file
• expected output midi file

each set in a separate directory

running the library on 2 first inputs and perform a diff on the expected output midi file and the output given by the library.

a bijective "midi file <-> text file" format would help keeping it all in plain text to ease with displaying the diff.

just a suggestion :)

[josephlarralde]

nice idea :)
we've been wondering about integrating MIDI capabilities directly into the library, but for the moment it only consumes and produces some non MIDI standard structs.
@rblard already made an ossia score midifile performer plugin, including a midifile parser which works pretty well :)
We could indeed use a MIDI library as a submodule, write adapters for the MIDI messages, and run some tests on MIDI files from this repo ...
To be investigated

[smoothdeveloper]

Maybe a textual representation of this non standard struct works the same for this purpose?

I think it makes adding tests and adjusting them better experience as it doesn't involve changing the test code.

It is a bit of upfront work, but generally makes the test codebase more resilient, especially to refactors on the actual code under test, etc.

[josephlarralde]

I just added libremidi to Catch2 tests and it seems to work.
Getting closer to easy testing of midi files ...