New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build/ to .gitignore #614

Open
M4v3R opened this Issue Jun 23, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@M4v3R
Contributor

M4v3R commented Jun 23, 2017

Shouldn't build directory be added to .gitignore? It does not make sense to have it in the repo, but then if I add it manually it will revert on any app-framework updates. Plus, it breaks npm run xcode command (build directory doesn't get copied over to app bundle).

@scriptPilot

This comment has been minimized.

Show comment
Hide comment
@scriptPilot

scriptPilot Jun 29, 2017

Owner

@M4v3R - Can you please add information to your issue ... so, what is your system, which errors you get while running npm run xcode?

Owner

scriptPilot commented Jun 29, 2017

@M4v3R - Can you please add information to your issue ... so, what is your system, which errors you get while running npm run xcode?

@mfkenson

This comment has been minimized.

Show comment
Hide comment
@mfkenson

mfkenson Aug 9, 2017

it seems that @M4v3R reported two things.

  1. He wants the .gitignore file includes build/ directory. Currently the .gitignore file is re-generated on every build. I also want to customize my .gitignore file. I want to exclude the IDE config files.

  2. Second issue is that npm run xcode does not use latest project source. I agree that

mfkenson commented Aug 9, 2017

it seems that @M4v3R reported two things.

  1. He wants the .gitignore file includes build/ directory. Currently the .gitignore file is re-generated on every build. I also want to customize my .gitignore file. I want to exclude the IDE config files.

  2. Second issue is that npm run xcode does not use latest project source. I agree that

@capgros

This comment has been minimized.

Show comment
Hide comment
@capgros

capgros Aug 30, 2017

It would be great to be able to edit .gitignore and add custom folders.

Also add build folder in default .gitignore file as it's not source.

capgros commented Aug 30, 2017

It would be great to be able to edit .gitignore and add custom folders.

Also add build folder in default .gitignore file as it's not source.

@scriptPilot scriptPilot added enhancement and removed question labels Oct 18, 2017

@scriptPilot scriptPilot added prio and removed prio labels Oct 27, 2017

@scriptPilot

This comment has been minimized.

Show comment
Hide comment
@scriptPilot

scriptPilot Nov 3, 2017

Owner

Rollback

Owner

scriptPilot commented Nov 3, 2017

Rollback

@scriptPilot scriptPilot reopened this Nov 3, 2017

@scriptPilot scriptPilot reopened this Nov 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment