New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp dependency loading and installation #143

Closed
jrusbatch opened this Issue Mar 20, 2013 · 5 comments

Comments

Projects
None yet
4 participants
@jrusbatch
Member

jrusbatch commented Mar 20, 2013

Part of #141.

  • In addition to installing the packages specified by the packages.config file, the scriptcs -install command should also copy the binaries contained within the NuGet packages into the script's bin directory.
  • When scriptcs file.csx is run with the -restore param we will copy the binaries from the packages to the bin folder. This is useful if one used nuget to install packages over scriptcs install. It is also useful if either the packages, or if the bin folder got deleted / corrupted.
  • When scriptcs file.csx is run without -restore we will not copy any binaries. This should significantly improve startup performance.
@follesoe

This comment has been minimized.

Show comment
Hide comment
@follesoe

follesoe Mar 22, 2013

For the Sublime Text plugin, I assume the default build parameters should not use the -restore param, and perhaps offer additional commands/menu items to do scriptcs -install and scriptcs -restore?

follesoe commented Mar 22, 2013

For the Sublime Text plugin, I assume the default build parameters should not use the -restore param, and perhaps offer additional commands/menu items to do scriptcs -install and scriptcs -restore?

@jrusbatch

This comment has been minimized.

Show comment
Hide comment
@jrusbatch

jrusbatch Mar 22, 2013

Member

@follesoe Correct. We want to do as little IO as possible by default when executing the user's scripts. The additional commands sound like a great idea.

Member

jrusbatch commented Mar 22, 2013

@follesoe Correct. We want to do as little IO as possible by default when executing the user's scripts. The additional commands sound like a great idea.

@filipw

This comment has been minimized.

Show comment
Hide comment
@filipw

filipw Mar 22, 2013

Member

@follesoe great ideas!
in #142 we mention another flag too -> scriptcs -clean

Also, since we are already talking about that a scriptcs -debug for sublime would be very welcome too :)

Member

filipw commented Mar 22, 2013

@follesoe great ideas!
in #142 we mention another flag too -> scriptcs -clean

Also, since we are already talking about that a scriptcs -debug for sublime would be very welcome too :)

@khellang

This comment has been minimized.

Show comment
Hide comment
@khellang

khellang Mar 22, 2013

Member

Should the -restore command also run the script?

Member

khellang commented Mar 22, 2013

Should the -restore command also run the script?

@filipw

This comment has been minimized.

Show comment
Hide comment
@filipw

filipw Mar 23, 2013

Member

this issue is taken by @khellang

Member

filipw commented Mar 23, 2013

this issue is taken by @khellang

jrusbatch added a commit that referenced this issue Mar 27, 2013

Merge pull request #145 from khellang/script-load-revamp
Dependency loading and installation revamp

Fixes #143

@jrusbatch jrusbatch closed this Mar 30, 2013

ztone pushed a commit to ztone/scriptcs that referenced this issue May 4, 2014

Merge pull request #145 from khellang/script-load-revamp
Dependency loading and installation revamp

Fixes #143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment