Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for :references, :usings, :vars and :help in REPL #830

Merged
merged 13 commits into from Dec 21, 2014

Conversation

@filipw
Copy link
Member

commented Sep 9, 2014

This PR introduces support for the following new REPL commands. Everything works on both Mono and Roslyn.

Additionally added a Description to REPL commands to support :help and introduced IReplEngine as a stepping stone to separate scripting and REPL in the future.

:help

screenshot 2014-09-09 17 31 22

screenshot 2014-09-09 17 31 47

:vars

screenshot 2014-09-09 17 32 43
screenshot 2014-09-09 17 33 17

Note - there are some small rendering differences due to the fact we rely on the internal mono functionality here. Semantically, it's all the same though.

:references

screenshot 2014-09-09 17 33 59
screenshot 2014-09-09 17 34 56

:usings

screenshot 2014-09-09 17 36 17
screenshot 2014-09-09 17 36 41

@luisrudge

This comment has been minimized.

Copy link

commented Sep 9, 2014

awesome! 👍

@dschenkelman

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2014

@filipw this is fantastic man! awesome job

@filipw

This comment has been minimized.

Copy link
Member Author

commented Sep 9, 2014

travis CI failed earlier due to some network issues, but it's all green now

@glennblock

This comment has been minimized.

Copy link
Member

commented Sep 9, 2014

Awesome work man!

On Tue, Sep 9, 2014 at 12:07 PM, Filip W notifications@github.com wrote:

travis CI failed earlier due to some network issues, but it's all green now


Reply to this email directly or view it on GitHub
#830 (comment).

@paulbouwer

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2014

Great work @filipw - this looks awesome.

@ryanrousseau

This comment has been minimized.

Copy link
Contributor

commented Sep 13, 2014

This looks great! 👍

@adamralph adamralph added the feature label Oct 6, 2014

@khellang

This comment has been minimized.

Copy link
Member

commented Oct 23, 2014

I'd love to see this in. Anyone object?

@filipw filipw referenced this pull request Nov 13, 2014
11 of 11 tasks complete
@adamralph

This comment has been minimized.

Copy link
Contributor

commented Nov 13, 2014

@filipw can you rebase please?

@adamralph

This comment has been minimized.

Copy link
Contributor

commented Dec 17, 2014

Assigned to @filipw for rebasing.

@filipw please clear the assignee after the rebase.

@filipw filipw force-pushed the filipw:feature/show branch from 7b70c62 to cf81a0f Dec 20, 2014

@filipw

This comment has been minimized.

Copy link
Member Author

commented Dec 20, 2014

rebased

@filipw filipw assigned adamralph and unassigned filipw Dec 20, 2014

@adamralph

This comment has been minimized.

Copy link
Contributor

commented Dec 21, 2014

Thanks @filipw. Unfortunately the merge of #769 has broken it so it will need to be rebased again 😦

@adamralph adamralph assigned filipw and unassigned adamralph Dec 21, 2014

@filipw filipw force-pushed the filipw:feature/show branch from cf81a0f to 5652b38 Dec 21, 2014

@filipw

This comment has been minimized.

Copy link
Member Author

commented Dec 21, 2014

rebased again; there were indeed some code paths that were incompatible

@filipw filipw assigned adamralph and unassigned filipw Dec 21, 2014

@adamralph

This comment has been minimized.

Copy link
Contributor

commented Dec 21, 2014

Great! I'm on it...

@adamralph

This comment has been minimized.

Copy link
Contributor

commented Dec 21, 2014

I'm taking the new commands out for a test drive and I have to say they are awesome! 👏

adamralph added a commit that referenced this pull request Dec 21, 2014

Merge pull request #830 from filipw/feature/show
Added support for :references, :usings, :vars and :help in REPL

@adamralph adamralph merged commit 148e0f6 into scriptcs:dev Dec 21, 2014

2 checks passed

continuous-integration/travis-ci The Travis CI build passed
Details
default Finished TeamCity Build scriptcs :: CI Build (dev) : Tests passed: 345
Details
@adamralph

This comment has been minimized.

Copy link
Contributor

commented Dec 21, 2014

Great work @filipw.

I did some refactoring whilst reviewing the code and sent a PR - #877

@filipw

This comment has been minimized.

Copy link
Member Author

commented Dec 21, 2014

w00t!
On Dec 21, 2014 5:21 PM, "Adam Ralph" notifications@github.com wrote:

Merged #830.


Reply to this email directly or view it on GitHub.

@adamralph adamralph added this to the v0.12 milestone Dec 21, 2014

@adamralph adamralph referenced this pull request Dec 23, 2014

filipw added a commit that referenced this pull request Dec 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.