Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring after #830 #877

Merged
merged 3 commits into from Dec 23, 2014
Merged

refactoring after #830 #877

merged 3 commits into from Dec 23, 2014

Conversation

adamralph
Copy link
Contributor

  • introduce IRepl
  • move IReplEngine to own file
  • add guards
  • remove redundant code
  • fix code formatting
  • add readonly

also fixes #434

@filipw
Copy link
Member

filipw commented Dec 23, 2014

you should also register IRepl against Repl in the services builder, inject it so that it's not newed up, and expose it publicly to allow for overrides like all the other services. This was the goal of #434.

@adamralph
Copy link
Contributor Author

Will do.

 - redundant code
 - line length
 - guard clauses
 - EOL at end of file
 - readonly fields
 - replace if with null coalesce
 - replace if with inline conditional
 - whitespace
@adamralph
Copy link
Contributor Author

Done.

@adamralph adamralph assigned filipw and unassigned adamralph Dec 23, 2014
@filipw
Copy link
Member

filipw commented Dec 23, 2014

great! thank you!

filipw added a commit that referenced this pull request Dec 23, 2014
@filipw filipw merged commit 09bb9af into scriptcs:dev Dec 23, 2014
@adamralph adamralph deleted the refactor-830 branch December 23, 2014 11:36
@adamralph adamralph added this to the v0.12 milestone Dec 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make REPL injectable and overrideable like other services
2 participants