test failures on windows firefox #108
Comments
I changed the title of this issue since it is not just windows where the tests are failing. I also see failures in firefox on mac. Other users have reported errors in Chrome on Mac. I need to determine what the problematic tests are and refactor them so they are less brittle. This is difficult since the tests are so tied to the dom and events that happen to it. |
Currently,
failing for me on mac/firefox. Same error as Andy reports in original comment. |
The first problem is fixable. Looks like a slight difference between the way that firefox and chrome handle scrolling (both are behaving correctly when I try it manually). I added a switch so that the expected result is different depending on whether or not it is firefox or chrome. I don't really like this solution since it will potentially require different test assertions for each browser. I have not tried this on phantomjs or safari, so I may need to add a switch statement for the assertion. The second problem is more insidious. The failures occur when there is a programmatic forward or back click. It looks like this action is triggered asynchronously, but there is no way to listen for the event's completion. Currently, I have an arbitrary 1000ms setTimeout after the if there is no forward/back event that I can look for, then I should be hooking into some other event instead rather than rely on a timeout. |
The commit above makes navHistoryTests.js more reliable. I removed the This wasn't enough. I also needed to add an extra 0ms Working for me now on firefox and chrome. Should test on windows, but I am feeling fairly confident about this change. |
This is working locally for me in the phantomjs build. Pushed cf2c1fa to github so that travis ci will pick it up. Let's see if it works. If so, I will close this bug. |
Running clientServerTests, two failures on Firefox (17.0.1). These work on chrome.
Nav History tests: testHistorycrumb5 (2, 6, 8)Rerun
Nav History tests: asyncTestToggleSide (1, 15, 16)Rerun
The text was updated successfully, but these errors were encountered: