Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

remove remaining dojo dependencies #58

Closed
aclement opened this Issue · 5 comments

3 participants

@aclement
Owner

the navigator and search (in file) still use dojo.

@nierajsingh
Collaborator

Pushed initial changes in navigator where span element creation has been replaced with jquery, and expand onclick handler is no longer using dojo hitch.

@nierajsingh
Collaborator

Pushed remaining dojo-to-jquery changes in the navigator to dojoless branch. All dojo usage is now removed from navigator.

@aclement aclement was assigned
@aclement
Owner

Based on Nieraj's final bits I've now removed dojo completely from Scripted. This reduces the size of the client folder (excluding 'components') from 14k to 3k. The new in file search is in master. Rather than covering the text it replaces the breadcrumb, in any editor. Supports the same options as the previous dojo based searcher. Some minor styling tweaks still necessary:

  • when navigator is open the drop shadow for the nav is overwritten by the search bar
  • the up/down arrows get slightly clipped

I'm sure people will let me know if the functionality isn't behaving like it used to with the old one.

@aclement aclement closed this
@aclement
Owner

those little style things annoyed me so I fixed them too.

@aeisenberg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.