remove remaining dojo dependencies #58

Closed
aclement opened this Issue Dec 13, 2012 · 5 comments

Comments

Projects
None yet
3 participants
Contributor

aclement commented Dec 13, 2012

the navigator and search (in file) still use dojo.

Contributor

nierajsingh commented Feb 13, 2013

Pushed initial changes in navigator where span element creation has been replaced with jquery, and expand onclick handler is no longer using dojo hitch.

Contributor

nierajsingh commented Feb 14, 2013

Pushed remaining dojo-to-jquery changes in the navigator to dojoless branch. All dojo usage is now removed from navigator.

aclement was assigned Feb 15, 2013

Contributor

aclement commented Feb 15, 2013

Based on Nieraj's final bits I've now removed dojo completely from Scripted. This reduces the size of the client folder (excluding 'components') from 14k to 3k. The new in file search is in master. Rather than covering the text it replaces the breadcrumb, in any editor. Supports the same options as the previous dojo based searcher. Some minor styling tweaks still necessary:

  • when navigator is open the drop shadow for the nav is overwritten by the search bar
  • the up/down arrows get slightly clipped

I'm sure people will let me know if the functionality isn't behaving like it used to with the old one.

aclement closed this Feb 15, 2013

Contributor

aclement commented Feb 15, 2013

those little style things annoyed me so I fixed them too.

Contributor

aeisenberg commented Feb 15, 2013

Nice work!

On Thu, Feb 14, 2013 at 11:33 PM, Andy Clement notifications@github.comwrote:

those little style things annoyed me so I fixed them too.


Reply to this email directly or view it on GitHubhttps://github.com/scripted-editor/scripted/issues/58#issuecomment-13595418.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment