Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Toggle side panel keybinding gets unbound #59

Open
aeisenberg opened this Issue Dec 13, 2012 · 8 comments

Comments

Projects
None yet
3 participants
Contributor

aeisenberg commented Dec 13, 2012

CMD/Ctrl + Shift + E

Press it once and the side panel opens as expected, press again and it closed. Press a third time and nothing happens.

Member

kdvolder commented Dec 14, 2012

It doesn't appear to get unbound at all. At least not according to the help panel.
I suspect its not the keybinding that gets lost but a bug in the 'toggle logic'.

Member

kdvolder commented Dec 14, 2012

Actually, looks like this is a focus-related problem.
The keybinding is not handled after the 'off' toggle because the editor no longer has focus.
Click in the editor and toggle works again.

Contributor

aeisenberg commented Dec 14, 2012

I can't reproduce this one any more. closing.

@aeisenberg aeisenberg closed this Dec 14, 2012

Contributor

aeisenberg commented Dec 14, 2012

Oops...closed before I saw your comment on focus. Even with that, I still can't reproduce. Can you? If so, worth re-oening.

Member

kdvolder commented Dec 14, 2012

Yes, I can. In FF. Just press the key several times in a row, happens every time.

Also it is indeed a focus issue. I also cannot type into the editor after the double togle. I have to click in it first.
I made a fix by adding the toggle sub-editor as a 'global' action. This makes the toggle work, but doesn't fix the focussing issue.

Member

kdvolder commented Dec 14, 2012

PS, I also fixed a problem with the toggle action not returning 'true' to indicate it has processed the event.

If not return true, then problems will ensue if the keybinding assigned to the action already has meaning to the browser. Plus... it results in a automatic 'double togle' if the action is marked as global, because it gets handled locally but then still bobles to get handled once more globally.

@kdvolder kdvolder reopened this Dec 14, 2012

Member

kdvolder commented Dec 14, 2012

Reopening, still have the focus issue.

Contributor

aclement commented Dec 19, 2012

Just commenting that Chris knows about this one, rapidly flipping has always been an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment