Improve navigator context menu click behaviour when closing the menu #82

Closed
nierajsingh opened this Issue Dec 18, 2012 · 2 comments

Comments

Projects
None yet
1 participant
@nierajsingh
Contributor

nierajsingh commented Dec 18, 2012

As of 0.3, the context menu closes on a single click after it is opened anywhere in the window, but this does not always behave correctly. Improve the way the navigator context menu is closed on click operations.

@nierajsingh

This comment has been minimized.

Show comment
Hide comment
@nierajsingh

nierajsingh Jan 3, 2013

Contributor

Changed how context menu is opened and then closed on subsequent clicks. Now, there are two mousedown event handlers, one on window to close the context menu when clicking outside the context menu area, and one on the context menu itself, which prevents propagation of the mousedown event when a user clicks on the context menu area. Leaving the issue open until further testing is done to ensure context menu behaves correctly when being opened and closed.

Contributor

nierajsingh commented Jan 3, 2013

Changed how context menu is opened and then closed on subsequent clicks. Now, there are two mousedown event handlers, one on window to close the context menu when clicking outside the context menu area, and one on the context menu itself, which prevents propagation of the mousedown event when a user clicks on the context menu area. Leaving the issue open until further testing is done to ensure context menu behaves correctly when being opened and closed.

@nierajsingh

This comment has been minimized.

Show comment
Hide comment
@nierajsingh

nierajsingh Mar 1, 2013

Contributor

Context menu seems to close consistently when clicking outside the context menu for 0.4.

Contributor

nierajsingh commented Mar 1, 2013

Context menu seems to close consistently when clicking outside the context menu for 0.4.

@nierajsingh nierajsingh closed this Mar 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment