Skip to content

There is a problem with text in dialogs not being received #163

Open

Description

@scripting

I've gotten a bunch of reports on this, if you have a dialog that's waiting for text to be entered, sometimes when you type into the dialog nothing happens. An example:

image

I'm looking into it, I don't know what's causing it -- it must be a recent change. Will keep you posted here.

Activity

  1. scripting commented on Jan 3, 2023

    @scripting
    OwnerAuthor

    I believe I found and fixed this vexing problem.

    Here's my theory of what was going on, for future reference.

    1. The problem was introduced when I added keyboard navigation in the Feed List page.
    2. In order for this to work, the Feed List code has to be listening to the keyboard.
    3. However when there's a dialog in front of the Feed List, it should not be listening to the keyboard. It was.
    4. The fix was to check to see if the "ask dialog" was in front when a key is pressed and if so, the Feed List ignores the keystroke.
    5. Everyone is happy. 😄

    The reason I'm posting this here even though no one reported the problem here, is so that people who are listening can test this.

    Basically if you see the "ask dialog" freeze. It's used whenever FeedLand asks you to type a string.

    This gives you an idea of how tricky software can be, and how a new feature in one area can break a feature in a very distant part.

  2. mistersugar commented on Jan 4, 2023

    @mistersugar
    Collaborator

    I am able to test the "ask dialog" but I am seeing a frozen dialog on the Search results page:

    Starting on the "My feed list" page, I selected the Menu command "Search feeds ..." The search dialog appears, and I am able to type a word ('peace'). I clicked OK, and the Search results page appeared with 3 results. Immediately in the console I see an error (screenshot attached). I can put the cursor in the search field now anywhere in or after 'peace' but I can't delete or type additional characters.

    Screenshot 2023-01-03 at 8 43 11 PM

    I am using Feedland v0.4.14 in Safari

  3. scripting commented on Jan 4, 2023

    @scripting
    OwnerAuthor

    @mistersugar -- i am able to reproduce that here. i'm going to look into fixing it now. ;-)

  4. scripting commented on Jan 4, 2023

    @scripting
    OwnerAuthor

    @mistersugar -- i believe i have this fixed now. you should be able to type into the text entry box on the search page, to search for something new.

  5. akaKenSmith commented on Jan 4, 2023

    @akaKenSmith
    Collaborator

    It looks functional here, text entering and searches going through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions