Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in mime package #7

Closed
davisshaver opened this issue Sep 16, 2017 · 2 comments
Closed

Breaking change in mime package #7

davisshaver opened this issue Sep 16, 2017 · 2 comments

Comments

@davisshaver
Copy link

@davisshaver davisshaver commented Sep 16, 2017

lookup() renamed to getType(). https://www.npmjs.com/package/mime

Should we pin to v1.x or update? Glad to put a PR together. I've switched to getType() in it seems to work FWIW.

@scripting
Copy link
Owner

@scripting scripting commented Sep 16, 2017

Thanks for the report. I just made the fix, it's in v0.7.6.

FWIW -- I don't buy this "breaking change" thing. I suppose there might possibly be times when you have to release a breaking change. But this seems gratuitous to me.

Funny thing is that I have a perfectly good MIME translator function in daveutils, but I switched to use this package to be more Node-like. Oy.

@scripting
Copy link
Owner

@scripting scripting commented May 13, 2018

Update: More trouble with the mime package. At random times, I'd get this error message in the log, after the server stopped running:

Object #<Mime> has no method 'getType'

It happened twice. I fixed it by reinstalling the app. The third time, I just replaced the package with the daveutils routine that does the same thing. One less dependency on a tiny package that believes in breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants