Skip to content

inconsistent use of "=" and "==" in build.sh #165

Closed
asmblur opened this Issue Jul 30, 2013 · 0 comments

2 participants

@asmblur
asmblur commented Jul 30, 2013

In 'build.sh', both '=' and '==' are used for testing string equality of strings. When running build.sh on Ubuntu 13.04(and other Debian-based distros which use 'dash' for the default implementation of sh), the use of '==' results in the following:

$ ./build.sh
./build.sh: 4: [: amo: unexpected operator
./build.sh: 4: [: staging: unexpected operator
./build.sh: 7: [: test: unexpected operator
Creating working directory ...
Creating scriptish-2013.07.30.beta.xpi ...
Cleaning up temporary files ...
./build.sh: 60: [: amo: unexpected operator
./build.sh: 60: [: staging: unexpected operator

Solution: replace uses of '==' with '=' on lines 4, 7 and 60 in build.sh

@erikvold erikvold was assigned Jul 31, 2013
@erikvold erikvold closed this in 2a39849 Jul 31, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.