Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Consider implementing Greasemonkey's fucked up @grant none behavior #182

Closed
nmaier opened this Issue · 1 comment

2 participants

@nmaier
Collaborator

In GM, when a user script has @grant none, either by explicitly specifying this in the header or when the horrible grant sniffing doesn't find any special API in the code or comments(!), then the behavior of the sandbox changes: The sandbox will be created with wantXRays: false, causing window to be unwrapped, so that window === unsafeWindow.

IMO, this is completely confusing, especially because of the grant-sniffing, and a compatibility nightmare.
Since they wontfixed greasemonkey/greasemonkey#1801, this behavior is there to stay. For more details, see that issue.

To avoid further compatibility issues between scripts written with GM but installed in Scriptish, we might want to consider mirroring their behavior.

@erikvold Thoughts?

@erikvold
Owner

I'd rather not make the change that GM did, and keep wantXRays: true for now. @nmaier do you concur?

@erikvold erikvold closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.