Skip to content

Loading…

Disabling script caching will not actually save memory #185

Open
nmaier opened this Issue · 2 comments

2 participants

@nmaier
scriptish member

Script caching was turned off in 691b658, giving memory consumption as the primary reason.

However, the script is still kept in memory:
https://github.com/scriptish/scriptish/blob/6dfd6b03bcbb377aa2fd515b686d288f2fc6af25/extension/modules/script/cachedresource.js#L21

Also, since this was "broken" for ages, but nobody complained about memory use, I suggest toggling the pref default to true.

@nmaier
scriptish member

It was never my intension to conserve memory when I originally wrote the stuff. Always setting the property was a bad idea, anyway. ac7f143 fixed that.

I'd still like to get some input on the default true part. @erikvold @supahgreg

@erikvold
scriptish member

@nmaier I'm ok with setting the pref to true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.