Scriptish will break completely when merge Regexp is enabled in some case #19

Closed
dindog opened this Issue Sep 20, 2012 · 1 comment

Projects

None yet

2 participants

@dindog
// ==UserScript==
// @name                      testcase
// @include         http://tieba.baidu.com/*
// @include         http://tieba.baidu.com.cn/*
// ==/UserScript==

Throw error:
Timestamp: 2012/9/21 0:16:15
Error: SyntaxError: unmatched ) in regular expression
Source File: resource://scriptish/utils/Scriptish_mergeRegExps.js
Line: 21

The pop-up menu mess up, no script will work.

@dindog

It's the merger's bug, it merge the above string to

 ^http:\\/\\/tieba\\.baidu\\.com\\(?:.cn\\/.*$|/.*$)

which escaped the "(" before ?: by mistake

@nmaier nmaier was assigned Sep 20, 2012
@nmaier nmaier added a commit that closed this issue Sep 20, 2012
@nmaier nmaier Fix regexpmerger escape character bug
Closes GH-19
e636052
@nmaier nmaier closed this in e636052 Sep 20, 2012
@nmaier nmaier added a commit to downthemall/downthemall that referenced this issue Sep 1, 2016
@nmaier nmaier Fix regexpmerger escape bug d652351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment