Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quotes to paths used in run #2

Merged
merged 5 commits into from Feb 26, 2018

Conversation

Tyil
Copy link
Member

@Tyil Tyil commented Feb 26, 2018

Variables in << >> contstructs are split on whitespace, which is different from
what I gathered from earlier discussion. This in turn led to paths with spaces
breaking normal usage. This patch applies quotes to such arguments, in order to
make App::Assixt behave as expected.

Closes #1

Variables in << >> contstructs are split on whitespace, which is different from
what I gathered from earlier discussion. This in turn led to paths with spaces
breaking normal usage. This patch applies quotes to such arguments, in order to
make App::Assixt behave as expected.

Closes #1
@Tyil Tyil requested a review from samcv February 26, 2018 10:28
Copy link

@samcv samcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Tyil Tyil merged commit 2244128 into master Feb 26, 2018
@Tyil Tyil deleted the add-quotes-to-avoid-whitespace-splitting branch February 26, 2018 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants