Fix: write final pos back #16
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue: we forget to write final sponge state position back in #12.
DuplexChallengerVariablecalledobserve_slice_optwhich is equivalent toobserve_slicebut costs much less cycles.test_multi_observe.cmd:
RUST_LOG=info,p3_=warn cargo test --release --test recursion test_multi_observe --package openvm-native-recursion --features "metrics,openvm-circuit/stark-debug,cuda" -- --nocapture.