feat: upgrade L1GasOracle predeploy in GalileoV2 upgrade #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #366 will not alter performanceComparing Summary
|
frisitano
reviewed
Nov 26, 2025
Collaborator
frisitano
left a comment
frisitano
left a comment
There was a problem hiding this comment.
Looks good. Do we have any test coverage to ensure the correct fee is being applied? This PR has state transition testing but not fee correctness testing for the different cases, pre-Galileo V2 and post-Galileo V2.
Thegaram
commented
Nov 26, 2025
This was referenced Nov 26, 2025
frisitano
approved these changes
Nov 27, 2025
Collaborator
frisitano
left a comment
frisitano
left a comment
There was a problem hiding this comment.
Left a few comments inline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: