-
Notifications
You must be signed in to change notification settings - Fork 5
feat(rpc): Modify getL1Message* rpc to acces L1MesageKey #378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
frisitano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I've added a few comments inline. Additionally, it would be great if we could add a few tests:
- One round trip of any vairant (serialize and then deserialze)
- One or two hand crafted serialized instances and then deserialize to ensure we can construct the correct enum variant. This gives us confidence in the rpc API we can expect.
CodSpeed Performance ReportMerging #378 will not alter performanceComparing Summary
|
frisitano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! lgtm
Fixes #372
get_l1_message_by_indexnow takes aL1MessageKeyinstead of anindex: u64GetL1MessageByIndexunderDatabaseQuerytakes aL1MessageKey