Skip to content

Conversation

@varun-doshi
Copy link
Contributor

Fixes #372

  • get_l1_message_by_index now takes a L1MessageKey instead of an index: u64
  • GetL1MessageByIndex under DatabaseQuery takes a L1MessageKey

Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I've added a few comments inline. Additionally, it would be great if we could add a few tests:

  • One round trip of any vairant (serialize and then deserialze)
  • One or two hand crafted serialized instances and then deserialize to ensure we can construct the correct enum variant. This gives us confidence in the rpc API we can expect.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 21, 2025

CodSpeed Performance Report

Merging #378 will not alter performance

Comparing varun-doshi:varun/get-l1-msg (f0f9e4f) with main (f64369c)

Summary

✅ 2 untouched

Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! lgtm

@frisitano frisitano merged commit 24582e4 into scroll-tech:main Oct 22, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RPC] Modify getL1Message* rpc to acces L1MesageKey

2 participants