feat: skipped l1 messages #380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #380 will not alter performanceComparing Summary
|
frisitano
reviewed
Oct 21, 2025
Collaborator
frisitano
left a comment
frisitano
left a comment
There was a problem hiding this comment.
Added a comment inline.
frisitano
reviewed
Oct 21, 2025
| // queue index in descending order. This ensures that we get the latest message | ||
| // included in a block before the provided block number. | ||
| if let Some(record) = models::l1_message::Entity::find() | ||
| .filter(models::l1_message::Column::L2BlockNumber.lt(block_number as i64)) |
Collaborator
There was a problem hiding this comment.
We should consider the case where the last message in a batch skipped and update the L1MessageKey::BlockNumber query to account for it.
frisitano
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
skippedindex and column on the l1 messages table in order to avoid sequencing skipped L1 messages.