feat(blob-uploader): support codec v8 #1707
Conversation
WalkthroughThe changes update the version tag in the versioning file to "v4.5.35" and expand the codec version handling in the blob uploader controller to treat both Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant BlobUploader
participant encoding
Caller->>BlobUploader: constructBlobCodec(version, ...)
alt version is CodecV7 or CodecV8
BlobUploader->>encoding: Create Batch with fields (Index, ParentBatchHash, Chunks, PrevL1MessageQueueHash, PostL1MessageQueueHash, Blocks)
else version is other
BlobUploader->>encoding: Handle other codecs as before
end
BlobUploader-->>Caller: Return constructed batch
Estimated code review effort1 (~2 minutes) Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
rollup/internal/controller/blob_uploader/blob_uploader.go (1)
146-155: Update comment to reflect Codec V8 inclusion
allBlocksis now collected for V7 and V8, yet the in-line comment still reads “collect blocks for CodecV7”.
Keeping comments in sync with behaviour avoids future confusion.- var allBlocks []*encoding.Block // collect blocks for CodecV7 + var allBlocks []*encoding.Block // collect blocks for CodecV7/V8
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
common/version/version.go(1 hunks)rollup/internal/controller/blob_uploader/blob_uploader.go(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: tests
- GitHub Check: check
- GitHub Check: tests
🔇 Additional comments (2)
common/version/version.go (1)
8-8: Version bump looks goodNo issues spotted with the patch-level bump.
rollup/internal/controller/blob_uploader/blob_uploader.go (1)
170-178: No action required: CodecV8 Batch fields match V7
Upstreamencoding.Batchstill defines the same fields for V7 and V8—there were no additions or removals in the struct itself. Both codec implementations ignore theTotalL1MessagePoppedBeforefield (it isn’t used in V7/V8 encoding), and the V7/V8 tests instantiate batches without setting it (e.g. incodecv7_test.goandcodecv8_test.go). Reusing the same literal inblob_uploader.gois correct.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1707 +/- ##
========================================
Coverage 39.62% 39.62%
========================================
Files 237 237
Lines 18970 18970
========================================
Hits 7516 7516
Misses 10714 10714
Partials 740 740
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Purpose or design rationale of this PR
Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?
Enable blob-uploader to support codecv8
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tagincommon/version.gobeen updated or have you addedbump-versionlabel to this PR?Breaking change label
Does this PR have the
breaking-changelabel?Summary by CodeRabbit
New Features
Chores