-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gas-oracle): fetch base fee from the latest L1 block #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinlyguo
changed the title
fix(gas-oracle): fetch base fee of the latest block
fix(gas-oracle): fetch base fee from the latest L1 block
Sep 4, 2023
colinlyguo
requested review from
Thegaram,
zimpha,
georgehao,
HAOYUatHZ and
mask-pp
September 4, 2023 07:12
Codecov Report
@@ Coverage Diff @@
## develop #920 +/- ##
===========================================
+ Coverage 49.23% 49.59% +0.35%
===========================================
Files 95 95
Lines 9899 9906 +7
===========================================
+ Hits 4874 4913 +39
+ Misses 4619 4580 -39
- Partials 406 413 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
HAOYUatHZ
reviewed
Sep 4, 2023
database/migrate/migrations/00012_drop_unique_l1_block_number.sql
Outdated
Show resolved
Hide resolved
HAOYUatHZ
reviewed
Sep 4, 2023
HAOYUatHZ
reviewed
Sep 4, 2023
colinlyguo
force-pushed
the
fix-gas-oracle-delay
branch
from
September 4, 2023 07:22
e40a895
to
368272b
Compare
Thegaram
reviewed
Sep 4, 2023
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
colinlyguo
force-pushed
the
fix-gas-oracle-delay
branch
from
September 4, 2023 09:20
d80e8f3
to
ef642a2
Compare
georgehao
previously approved these changes
Sep 4, 2023
georgehao
previously approved these changes
Sep 5, 2023
zimpha
reviewed
Sep 5, 2023
georgehao
approved these changes
Sep 5, 2023
zimpha
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or design rationale of this PR
Previously, the gas oracle sender utilized the base fee of the most recently finalized block to update the L2 gas oracle's recommended L1 gas price. This method caused a delay of at least 12.8 minutes, which is equivalent to 2 epochs.
In this PR, we have optimized the process to reduce this delay.
Key Changes:
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated or have you addedbump-version
label to this PR?Breaking change label
Does this PR have the
breaking-change
label?