Skip to content

getmatches breaks syntastic for vim < 7.1 #250

Closed
prat0088 opened this Issue May 15, 2012 · 8 comments

8 participants

@prat0088

Commit cda7186 introduced the use of getmatches. getmatches appears to have been added in patch 7.1.040 ( http://www.cs.csubak.edu/docs/vim/version7.html ). At work, I only have access to vim 7.0. It would be great if syntastic had 7.0 support.

@greydet
greydet commented Aug 20, 2012

I am facing the same issue.
Is it possible to add a workaround or at least to check the vim version for compatibility when loading the syntastic plug-in?

@neilsh
neilsh commented Aug 25, 2012

Same here.

@zonca
zonca commented Sep 22, 2012

yes, got the same problem

@erikdaniel

Same here.

@rbrown rbrown added a commit to rbrown/syntastic that referenced this issue Sep 27, 2012
@rbrown rbrown Highlighting requires vim-7.1.040
Fixes Issue #250
4bb4ec6
@rbrown
rbrown commented Sep 27, 2012

The patch above fixes this but shouldn't really be necessary, as putting let g:syntastic_enable_highlighting = 0 in .vimrc should stop getmatches from being called

@dbarnett

I think the logic on this check was wrong:

" highlighting requires getmatches introduced in 7.1.040
if g:syntastic_enable_highlighting == 1 &&
            \ (v:version < 701 || v:version == 701 && has('patch040'))
    let g:syntastic_enable_highlighting = 1
endif

For starters, it should be let g:syntastic_enable_highlighting = 0 or it will only every change it from 1 to 1. Also, the has('patch040') check is backwards now. I think the correct logic is

" highlighting requires getmatches introduced in 7.1.040
if g:syntastic_enable_highlighting == 1 &&
            \ (v:version < 701 || v:version == 701 && !has('patch040'))
    let g:syntastic_enable_highlighting = 0
endif
@scrooloose scrooloose added a commit that closed this issue Nov 17, 2012
@scrooloose fix a bug with highlighting and getmatches
Highlighting requires vim >= 7.1 with patch 40. It should be disabled
otherwise.

Fix a bug with the version check.

Closes #250.
36db8f4
@scrooloose
Owner

Yeah, cant believe I didnt spot that. Just pushed a fix - can you confirm that it works as expected?

@dbarnett

Yep, I can confirm 36db8f4 fixes the behavior for me. Thanks!

@patrickdepinguin patrickdepinguin referenced this issue in unblevable/quick-scope Oct 8, 2015
Closed

Requires vim >= 7.1.040 #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.