osmpbf header version pointer #8

Closed
asalic opened this Issue Feb 1, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@asalic

asalic commented Feb 1, 2013

Hi,

First of all, this is a very good and useful library. Thanks a lot for the good work!
Secondly, there is a small problem with the declaration of the version in osmpbf.h. Right now it is declared as a const pointer to char. The problem with this is that it is not really a full constant. It should be either:
const char version[] = "1.2.1";
or
const char* const version = "1.2.1";
I have problems when I'm including the header in multiple sources.

Thanks,
Andrei

@joto

This comment has been minimized.

Show comment
Hide comment
@joto

joto Sep 2, 2013

Collaborator

This is now fixed by making it a macro.

Collaborator

joto commented Sep 2, 2013

This is now fixed by making it a macro.

@joto joto closed this Sep 2, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment