Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relatedTarget cancels blur #473

Closed
chrisjbrown opened this issue Oct 2, 2019 · 0 comments · Fixed by #478
Closed

relatedTarget cancels blur #473

chrisjbrown opened this issue Oct 2, 2019 · 0 comments · Fixed by #478
Labels
Type: Bug The issue or pullrequest is related to a bug

Comments

@chrisjbrown
Copy link
Contributor

Describe the bug
Using the EditorMenuBubble when I select some text and focus outside of the editor the menu bubble remains visible

Steps to Reproduce / Codesandbox Example
Steps to reproduce the behavior:

  1. Go to https://codesandbox.io/embed/vue-issue-template-xi4ef
  2. highlight editor text
  3. click on input above editpr
  4. menu bar still shown

Codesandbox
https://codesandbox.io/embed/vue-issue-template-xi4ef

Expected behavior
the menu bubble hide

Environment

  • OS: Mac
  • Browser Brave
  • Desktop

Additional context
seems to be this bit of code which checks for relatedTarget (anything focusable) and bails out if it exists
https://github.com/scrumpy/tiptap/blob/24f61e02be0ed091f4735266df03433ceeda119c/packages/tiptap/src/Plugins/MenuBubble.js#L64-L71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Milestone
No milestone
1 participant
@chrisjbrown