New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security headers #15

Open
wants to merge 8 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@spacemonaut
Collaborator

spacemonaut commented Dec 3, 2018

Addresses #12. This is the branch currently found at https://artgame.scryfall.com/.

firefox_2018-12-03_23-05-07

@spacemonaut spacemonaut requested a review from csuhta Dec 3, 2018

index.js Outdated
const CONTENT_SECURITY_POLICY = [
"default-src *.scryfall.com",
"script-src *.scryfall.com 'unsafe-eval' 'unsafe-inline'",
"style-src *.scryfall.com 'unsafe-inline'",

This comment has been minimized.

@csuhta

csuhta Dec 4, 2018

Member

Allowing unsafe-inline cripples the value of CSP. Why does this app need those values?

This comment has been minimized.

@spacemonaut

spacemonaut Dec 9, 2018

Collaborator

I'll look into those an evening this week.

This comment has been minimized.

@spacemonaut

spacemonaut Dec 15, 2018

Collaborator

This should be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment