Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed Rubric 5 #57

Merged
merged 3 commits into from Jun 17, 2022
Merged

Conversation

heathernsmith77
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Heather seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jeffreycwitt
Copy link
Contributor

jeffreycwitt commented Jun 16, 2022

@heathernsmith77 it looks like we have a few issues in

checking diplomatic for bHY6yh-de1319/cod-acbnn_bHY6yh-de1319.xml
/home/runner/work/bHY6yh/bHY6yh/bHY6yh-de1319/cod-acbnn_bHY6yh-de1319.xml:72:43: error: ID "bHY6yh-de1319-Rd1e116" has already been defined
/home/runner/work/bHY6yh/bHY6yh/bHY6yh-de1319/cod-acbnn_bHY6yh-de1319.xml:67:66: error: first occurrence of ID "bHY6yh-de1319-Rd1e116"
/home/runner/work/bHY6yh/bHY6yh/bHY6yh-de1319/cod-acbnn_bHY6yh-de1319.xml:77:43: error: ID "bHY6yh-de1319-Rd1e116" has already been defined
/home/runner/work/bHY6yh/bHY6yh/bHY6yh-de1319/cod-acbnn_bHY6yh-de1319.xml:67:66: error: first occurrence of ID "bHY6yh-de1319-Rd1e116"
/home/runner/work/bHY6yh/bHY6yh/bHY6yh-de1319/cod-acbnn_bHY6yh-de1319.xml:89:44: error: ID "bHY6yh-de1319-Rd1e116" has already been defined
/home/runner/work/bHY6yh/bHY6yh/bHY6yh-de1319/cod-acbnn_bHY6yh-de1319.xml:67:66: error: first occurrence of ID "bHY6yh-de1319-Rd1e116"

Basically, three entries have duplicate ids.

<lb ed="#A"/>sospintate. </quote>
</p>
<p xml:id="bHY6yh-de1319-d1e131">
<ref xml:id="bHY6yh-de1319-Rd1e116"> Idem </ref> <quote xml:id="bHY6yh-de1319-Qd1e133" source="http://scta.info/resource/iob5_12@2-11"> deus dissipat cogita
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this ref id got copied over four times. We need to make sure the correct id is used for each <ref> so that this can sync with all the other transcriptions.

@jeffreycwitt jeffreycwitt merged commit 309c112 into scta-texts:master Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants