Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple Shade Slider #230

Closed
SeijiV13 opened this issue Sep 5, 2019 · 4 comments · Fixed by #231
Closed

Simple Shade Slider #230

SeijiV13 opened this issue Sep 5, 2019 · 4 comments · Fixed by #231
Assignees
@scttcper
Labels
released

Comments

@SeijiV13
Copy link
Contributor

SeijiV13 commented Sep 5, 2019

Hi, I would like to suggest a new feature for the color slider, this is a simple shade slider. this is just like a hue slider but the start color is the selected color from hue slider going to a darker color
Capture
@SeijiV13
Copy link
Contributor Author

SeijiV13 commented Sep 5, 2019

i've already worked on this and will request a PR

@scttcper
Copy link
Owner

scttcper commented Sep 5, 2019

Sounds good to me

@SeijiV13 SeijiV13 mentioned this issue Sep 5, 2019
Merged
@SeijiV13
Copy link
Contributor Author

SeijiV13 commented Sep 5, 2019

@scttcper already created a PR for this

@scttcper scttcper self-assigned this Sep 5, 2019
scttcper pushed a commit that referenced this issue Sep 5, 2019
@SeijiV13 @scttcper
feat: add shade component closes #230 (#231)
cea6532 
* added shade-slider component

* add shade.component to public api

* add shade-slider to build, cleanup imports and console.logs

* remove some duplicate imports

* set pointer when value changes instead of when attempting to handle change

this allows shade to be set when initializing component

* chore: upgrade dependencies

* add docs for shade slider, remove unused direction

* remove direction from test

* rename shade slider to shade picker and fix tests
@scttcper
Copy link
Owner

scttcper commented Sep 5, 2019

🎉 This issue has been resolved in version 4.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scttcper scttcper

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: added shade-slider component SeijiV13/ngx-color
2 participants
@scttcper @SeijiV13