Skip to content

Adam Anderson
scudco

  • Joined on Mar 25, 2008

Organizations

@internmatch
Mar 21, 2016
scudco closed pull request scudco/taza#5
@scudco
Added error validation in case environment key is not matched
Mar 21, 2016
scudco commented on pull request scudco/taza#5
@scudco

This should probably be opened against https://github.com/hammernight/taza

Mar 21, 2016
@scudco

I would be open to a PR for this since it appears unicode_utils is not addressing this performance problem. If possible, I'd like to see this work …

Mar 4, 2016
scudco commented on pull request stefanpenner/country_select#124
@scudco

Tests are looking good. I've got this on my own branch with the latest changes from country_select master using countries 2.0.0.pre.2 I think we'll…

Mar 4, 2016
@scudco
  • @scudco e327238
    Use latest countries 2.0.0.pre.2
Mar 4, 2016
Mar 4, 2016
scudco commented on pull request stefanpenner/country_select#124
@scudco

thanks, going to take a look now.

Mar 4, 2016
@scudco
Mar 4, 2016
@scudco
Mar 4, 2016
@scudco
Mar 4, 2016
@scudco
  • @scudco ff39718
    Add more exclusions based on latest rack requirements
Mar 3, 2016
@scudco
Mar 3, 2016
Mar 3, 2016
@scudco
  • @scudco 9543a75
    Update gemfiles and travis config to latest versions
Mar 3, 2016
@scudco
  • @scudco 9543a75
    Update gemfiles and travis config to latest versions
Mar 3, 2016
@scudco
Mar 3, 2016
@scudco
Mar 3, 2016
scudco commented on pull request stefanpenner/country_select#127
@scudco

thanks!

Mar 3, 2016
@scudco
  • @scudco 9c52084
    Merge pull request #127 from jjballano/multiple_selection_fix
  • @jjballano 4d64839
    Adding multiple option so that it generates a multi-select
  • 2 more commits »
Mar 3, 2016
@scudco
Fix an error when multiple selection is allowed.
3 commits with 19 additions and 8 deletions
Mar 3, 2016
scudco commented on pull request stefanpenner/country_select#127
@scudco

Just add multiple: true here so that it generates a multi-select.

Mar 3, 2016
scudco commented on pull request stefanpenner/country_select#127
@scudco

Right, okay, I think get that now that I realize only affects the option tags. Sorry about that.

Mar 2, 2016
scudco commented on pull request stefanpenner/country_select#127
@scudco

This seems to coincidentally work... I'm not sure that that's necessarily bad, but it seems like option_tags_options[:selected] should never be tra…

Mar 2, 2016
scudco commented on pull request stefanpenner/country_select#127
@scudco

In real testing with this code, I found that I needed to specify multiple: true to get this working. Were you getting a multi-select box just by sp…

Feb 29, 2016
scudco commented on pull request stefanpenner/country_select#127
@scudco

great job on the tests here :+1:

Feb 29, 2016
scudco commented on pull request stefanpenner/country_select#127
@scudco

Since you check again if option_tags_options[:selected].kind_of?(Array) maybe you should store that value in a variable or just have two separate b…

Feb 29, 2016
scudco commented on pull request stefanpenner/country_select#127
@scudco

this is very hard to read, imo essentially it's saying if x and then later unless y Can you move the unless into the if block or combine it with the

Feb 29, 2016
scudco commented on pull request stefanpenner/country_select#127
@scudco

Wow, great find. I never even though of using this in a multi-select. I'd say it was never explicitly supported.

Feb 22, 2016
@scudco

@netwire88 I think the simple_form README needs to be updated to not use the collection option for country_select. Either that, or it needs to corr…

Feb 22, 2016
@scudco
Something went wrong with that request. Please try again.