Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta tag support #23

Merged
merged 2 commits into from Jan 23, 2015
Merged

Meta tag support #23

merged 2 commits into from Jan 23, 2015

Conversation

WyriHaximus
Copy link
Member

Allow pages to set custom meta tags. The default is not to index anything but allow all links. Only pages with content should be indexed so a site doesn't pollute the search index and might be punished for it. The second thing I've added are feed tags for category and tag feeds added recently.

@simensen
Copy link
Member

I like this. I've been doing this a lot myself. I've just been using block named meta. What do you think about that?

@WyriHaximus
Copy link
Member Author

meta sounds good to me but the reason why I named it metaTags because it clarifies it's for meta tags and not other kinds of meta data.

@simensen
Copy link
Member

OK. The things I've been doing is:

  • meta (gets injected just before the local stylesheet is included)
  • styles (gets injected just before </head>)
  • script (gets injected just before </body>)

I'd love to come up w/ something that can be more consistent. I suppose we could do meta, style, script, or meta, styles, scripts?

I also think the idea of being more specific could be helpful. Maybe head_meta instead of metaTags? So head_meta, head_styles, scripts_after or something?

@WyriHaximus
Copy link
Member Author

head_meta, head_styles, scripts_after makes perfect sense because it's clear where things are going to be. Want me to extend that into this PR and update it? I might even consider adding head_scripts that is injected right after head_styles for small snippets that aren't blocking the loading of the page.

@simensen
Copy link
Member

Yep, that sounds good to me.

@simensen
Copy link
Member

Read: yes, if you want to make those changes and add it to this PR, that would be awesome. You can either add commits or rebase / squash. I'm fine with either.

@WyriHaximus
Copy link
Member Author

It will be only 1 other commit so not rebasing or squashing so the history is clear on why the changed happened.

@simensen
Copy link
Member

I won't get a notification when you push new code so ping the issue manually when you're ready for me to take a look again! Thanks. :)

@WyriHaximus
Copy link
Member Author

Will do :).

@WyriHaximus
Copy link
Member Author

ping

simensen added a commit that referenced this pull request Jan 23, 2015
@simensen simensen merged commit e63d195 into sculpin:master Jan 23, 2015
@simensen
Copy link
Member

Thanks!

@WyriHaximus WyriHaximus deleted the feature-metatags branch January 23, 2015 13:21
@WyriHaximus WyriHaximus mentioned this pull request Jan 23, 2015
wana4jp pushed a commit to wana4jp/sculpin-blog-skeleton that referenced this pull request Apr 19, 2018
wana4jp pushed a commit to wana4jp/sculpin-blog-skeleton that referenced this pull request Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants